Skip to content

Commit

Permalink
review: rename
Browse files Browse the repository at this point in the history
  • Loading branch information
jyoo0515 committed Feb 17, 2024
1 parent 612cc15 commit 8f8816e
Show file tree
Hide file tree
Showing 8 changed files with 54 additions and 59 deletions.
30 changes: 0 additions & 30 deletions proto/articulation.proto

This file was deleted.

2 changes: 1 addition & 1 deletion proto/error.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ package proto;
message ErrorDTO {
int32 code = 1;
string message = 2;
}
}
30 changes: 15 additions & 15 deletions proto/pronunciation.proto → proto/feedback.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,6 @@ syntax = "proto3";

package proto;

// sentence which user has to try to pronounce
message SentenceDTO {
int32 id = 1;
string text = 2;
}

message GetSetenceRequest {
int32 id = 1;
}

message GetSetenceResponse {
SentenceDTO sentence = 1;
}

message PronunciationFeedbackDTO {
int32 sentence_id = 1;
repeated int32 incorrect_indexes = 2;
Expand All @@ -30,6 +16,20 @@ message GetPronunciationFeebackRequest {
string audio_file_url = 2;
}

message SubmitPronunciationResponse {
message GetPronunciationResponse {
PronunciationFeedbackDTO pronunciation_feeback = 1;
}

message CommunicationFeedbackDTO {
int32 scene_id = 1;
string overall_feedback = 5;
}

message GetCommunicationFeedbackRequest {
int32 scene_id = 1;
string audio_file_url = 2;
}

message GetCommunicationFeedbackResponse {
CommunicationFeedbackDTO communication_feedback = 1;
}
3 changes: 1 addition & 2 deletions proto/history.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ syntax = "proto3";

package proto;

import "articulation.proto";
import "pronunciation.proto";
import "feedback.proto";

enum HistoryType {
HISTORY_TYPE_UNSPECIFIED = 0;
Expand Down
18 changes: 18 additions & 0 deletions proto/scene.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
syntax = "proto3";

package proto;

// information for sentence formation practice
message SceneDTO {
int32 id = 1;
string image_url = 2;
string question = 3;
}

message GetSceneRequest {
int32 id = 1;
}

message GetSceneResponse {
SceneDTO scene = 1;
}
17 changes: 17 additions & 0 deletions proto/sentence.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
syntax = "proto3";

package proto;

// sentence which user has to try to pronounce
message SentenceDTO {
int32 id = 1;
string text = 2;
}

message GetSetenceRequest {
int32 id = 1;
}

message GetSetenceResponse {
SentenceDTO sentence = 1;
}
7 changes: 2 additions & 5 deletions proto/topic.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@ syntax = "proto3";

package proto;

import "articulation.proto";
import "pronunciation.proto";

// topic used to select the theme of the session
message TopicDTO {
int32 id = 1;
string title = 2;
string thumbnail_url = 3;
repeated SentenceDTO sentences = 4;
repeated SceneDTO scenes = 5;
repeated string sentence_ids = 4;
repeated string scene_ids = 5;
}

message ListTopicsRequest {
Expand Down
6 changes: 0 additions & 6 deletions proto/user.proto
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ message UserDTO {
string id = 1;
string name = 2;
int32 age = 3;
DisorderType disorder_type = 4;
}

enum DisorderType {
DISORDER_TYPE_UNSPECIFIED = 0;
}

message GetUserRequest {
Expand All @@ -25,7 +20,6 @@ message UpdateUserRequest {
string id = 1;
optional string name = 2;
optional int32 age = 3;
DisorderType disorder_type = 4;
}

message UpdateUserResponse {
Expand Down

0 comments on commit 8f8816e

Please sign in to comment.