Feature/sumin step1 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmin21
commented
Oct 11, 2023
smmin21
commented
- JWT 회원가입/로그인 구현
jyoo0515
reviewed
Oct 11, 2023
src/main/resources/application.yml
Outdated
|
|
||
| jpa: | ||
| hibernate: | ||
| ddl-auto: create |
There was a problem hiding this comment.
다른 분들과 마찬가지로 ddl-auto 는 실제 서비스 환경에서 금기시 되는데 그 이유가 뭘까요?
jyoo0515
reviewed
Oct 11, 2023
inshining
reviewed
Nov 1, 2023
| // then | ||
| fail("예외가 발생해야 한다."); | ||
| } | ||
|
|
There was a problem hiding this comment.
로그인 테스트도 한 번 해보면 좋을 것 같아요!
inshining
approved these changes
Nov 1, 2023
jyoo0515
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.