-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete revamp #59
Merged
Complete revamp #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 93.29% 93.43% +0.14%
==========================================
Files 18 17 -1
Lines 537 503 -34
==========================================
- Hits 501 470 -31
+ Misses 36 33 -3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
obs_distribution(hmm, i)
(returning a single distribution) withobs_distributions(hmm)
(returning a vector of distributions)forward_backward
: it is now(\gamma, logL)
initial_distribution(hmm)
intoinitialization(hmm)
check_loglikelihood_increasing
intologlikelihood_increasing
Other changes
AbstractMatrix
for\xi
so that it can imitate the type and structure of the original transition matrix (e.g. sparse)Storage
types for each inference algorithm to simplify initializationeltype(hmm, obs)
HMMTest
submodule, addCategorical
distributions