Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify discrete aspect in README #117

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

adannenberg
Copy link
Contributor

clarify that the package is for the modeling of discrete-valued hidden state variables

Copy link
Owner

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Here's an example of GitHub review, where I suggest some modifications on your changes

README.md Outdated Show resolved Hide resolved
@gdalle gdalle changed the title Update README.md Clarify discrete aspect in README Oct 7, 2024
@adannenberg
Copy link
Contributor Author

adannenberg commented Oct 7, 2024 via email

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (1656f7d) to head (c9c0276).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          18       18           
  Lines         503      503           
=======================================
  Hits          479      479           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit a370596 into gdalle:main Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants