Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HMMBase optional in the test suite #111

Merged
merged 17 commits into from
Sep 30, 2024
Merged

Make HMMBase optional in the test suite #111

merged 17 commits into from
Sep 30, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Sep 29, 2024

  • Put HMMBase-dependent code in an extension of the internal package HMMTest
  • Split CI and test suite depending on whether we want to load HMMBase
  • Make some test sequences a little longer
  • Remove all @inbounds

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.07%. Comparing base (9802bad) to head (3bb007d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/inference/baum_welch.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          17       17           
  Lines         504      504           
=======================================
  Hits          454      454           
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 30, 2024 07:39
@gdalle gdalle merged commit 284189f into main Sep 30, 2024
7 of 8 checks passed
@gdalle gdalle deleted the gd/nohmmbase branch September 30, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant