Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronize for PR redeploy #236

Merged
merged 16 commits into from
Feb 1, 2024
Merged

Fix synchronize for PR redeploy #236

merged 16 commits into from
Feb 1, 2024

Conversation

doug0102
Copy link
Collaborator

@doug0102 doug0102 commented Jan 31, 2024

closes #232

The issue ended up being a combination of two things:

  1. incorrect publishUrl from the azure portal's generated publishing profile. Needs the format [web-app-name].scm.azurewebsites.net so I had to add an option to use SCM for webdeploy.
  2. I was escaping the publishing profile because of an error it gave me previously, but that seems to have resolved itself? And escaping the publishing profile was breaking it because the first character was unrecognized.

Still unsure how the first deployment works without any issues but a re-deploy was running into problems...

I also updated the node sync script to include the bicep file where the app is created, so everything should be running the same version. And I hid the publishing profile command outputs since it's sensitive data and if you view raw logs in github you could see it as an output.

@doug0102 doug0102 closed this Feb 1, 2024
@doug0102 doug0102 reopened this Feb 1, 2024
@doug0102 doug0102 requested review from vid and Phanoix February 1, 2024 16:41
@doug0102 doug0102 merged commit 0943504 into main Feb 1, 2024
7 checks passed
@doug0102 doug0102 deleted the pr-sync-fix branch February 1, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR deployments not working on sync
1 participant