-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into e2e-tests-reviews
- Loading branch information
Showing
325 changed files
with
49,743 additions
and
25,276 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,55 +18,51 @@ module.exports = { | |
comment: | ||
"This is an orphan module - it's likely not used (anymore?). Either use it or " + | ||
"remove it. If it's logical this module is an orphan (i.e. it's a config file), " + | ||
"add an exception for it in your dependency-cruiser configuration. By default " + | ||
"this rule does not scrutinize dot-files (e.g. .eslintrc.js), TypeScript declaration " + | ||
"files (.d.ts), tsconfig.json and some of the babel and webpack configs.", | ||
'add an exception for it in your dependency-cruiser configuration. By default ' + | ||
'this rule does not scrutinize dot-files (e.g. .eslintrc.js), TypeScript declaration ' + | ||
'files (.d.ts), tsconfig.json and some of the babel and webpack configs.', | ||
severity: 'warn', | ||
from: { | ||
orphan: true, | ||
pathNot: [ | ||
'(^|/)\\.[^/]+\\.(js|cjs|mjs|ts|json)$', // dot files | ||
'\\.d\\.ts$', // TypeScript declaration files | ||
'(^|/)tsconfig\\.json$', // TypeScript config | ||
'(^|/)(babel|webpack)\\.config\\.(js|cjs|mjs|ts|json)$' // other configs | ||
] | ||
'\\.d\\.ts$', // TypeScript declaration files | ||
'(^|/)tsconfig\\.json$', // TypeScript config | ||
'(^|/)(babel|webpack)\\.config\\.(js|cjs|mjs|ts|json)$', // other configs | ||
], | ||
}, | ||
to: {}, | ||
}, | ||
{ | ||
name: 'no-deprecated-core', | ||
comment: | ||
'A module depends on a node core module that has been deprecated. Find an alternative - these are ' + | ||
"bound to exist - node doesn't deprecate lightly.", | ||
comment: 'A module depends on a node core module that has been deprecated. Find an alternative - these are ' + "bound to exist - node doesn't deprecate lightly.", | ||
severity: 'warn', | ||
from: {}, | ||
to: { | ||
dependencyTypes: [ | ||
'core' | ||
], | ||
dependencyTypes: ['core'], | ||
path: [ | ||
'^(v8\/tools\/codemap)$', | ||
'^(v8\/tools\/consarray)$', | ||
'^(v8\/tools\/csvparser)$', | ||
'^(v8\/tools\/logreader)$', | ||
'^(v8\/tools\/profile_view)$', | ||
'^(v8\/tools\/profile)$', | ||
'^(v8\/tools\/SourceMap)$', | ||
'^(v8\/tools\/splaytree)$', | ||
'^(v8\/tools\/tickprocessor-driver)$', | ||
'^(v8\/tools\/tickprocessor)$', | ||
'^(node-inspect\/lib\/_inspect)$', | ||
'^(node-inspect\/lib\/internal\/inspect_client)$', | ||
'^(node-inspect\/lib\/internal\/inspect_repl)$', | ||
'^(v8/tools/codemap)$', | ||
'^(v8/tools/consarray)$', | ||
'^(v8/tools/csvparser)$', | ||
'^(v8/tools/logreader)$', | ||
'^(v8/tools/profile_view)$', | ||
'^(v8/tools/profile)$', | ||
'^(v8/tools/SourceMap)$', | ||
'^(v8/tools/splaytree)$', | ||
'^(v8/tools/tickprocessor-driver)$', | ||
'^(v8/tools/tickprocessor)$', | ||
'^(node-inspect/lib/_inspect)$', | ||
'^(node-inspect/lib/internal/inspect_client)$', | ||
'^(node-inspect/lib/internal/inspect_repl)$', | ||
'^(async_hooks)$', | ||
'^(punycode)$', | ||
'^(domain)$', | ||
'^(constants)$', | ||
'^(sys)$', | ||
'^(_linklist)$', | ||
'^(_stream_wrap)$' | ||
'^(_stream_wrap)$', | ||
], | ||
} | ||
}, | ||
}, | ||
{ | ||
name: 'not-to-deprecated', | ||
|
@@ -76,26 +72,21 @@ module.exports = { | |
severity: 'warn', | ||
from: {}, | ||
to: { | ||
dependencyTypes: [ | ||
'deprecated' | ||
] | ||
} | ||
dependencyTypes: ['deprecated'], | ||
}, | ||
}, | ||
{ | ||
name: 'no-non-package-json', | ||
severity: 'error', | ||
comment: | ||
"This module depends on an npm package that isn't in the 'dependencies' section of your package.json. " + | ||
"That's problematic as the package either (1) won't be available on live (2 - worse) will be " + | ||
"available on live with an non-guaranteed version. Fix it by adding the package to the dependencies " + | ||
"in your package.json.", | ||
'available on live with an non-guaranteed version. Fix it by adding the package to the dependencies ' + | ||
'in your package.json.', | ||
from: {}, | ||
to: { | ||
dependencyTypes: [ | ||
'npm-no-pkg', | ||
'npm-unknown' | ||
] | ||
} | ||
dependencyTypes: ['npm-no-pkg', 'npm-unknown'], | ||
}, | ||
}, | ||
{ | ||
name: 'not-to-unresolvable', | ||
|
@@ -105,24 +96,24 @@ module.exports = { | |
severity: 'error', | ||
from: {}, | ||
to: { | ||
couldNotResolve: true | ||
} | ||
couldNotResolve: true, | ||
}, | ||
}, | ||
{ | ||
name: 'no-duplicate-dep-types', | ||
comment: | ||
"Likely this module depends on an external ('npm') package that occurs more than once " + | ||
"in your package.json i.e. bot as a devDependencies and in dependencies. This will cause " + | ||
"maintenance problems later on.", | ||
'in your package.json i.e. bot as a devDependencies and in dependencies. This will cause ' + | ||
'maintenance problems later on.', | ||
severity: 'warn', | ||
from: {}, | ||
to: { | ||
moreThanOneDependencyType: true, | ||
// as it's pretty common to have a type import be a type only import | ||
// as it's pretty common to have a type import be a type only import | ||
// _and_ (e.g.) a devDependency - don't consider type-only dependency | ||
// types for this rule | ||
dependencyTypesNot: ["type-only"] | ||
} | ||
dependencyTypesNot: ['type-only'], | ||
}, | ||
}, | ||
|
||
/* rules you might want to tweak for your specific situation: */ | ||
|
@@ -135,8 +126,8 @@ module.exports = { | |
severity: 'error', | ||
from: {}, | ||
to: { | ||
path: '\\.(spec|test)\\.(js|mjs|cjs|ts|ls|coffee|litcoffee|coffee\\.md)$' | ||
} | ||
path: '\\.(spec|test)\\.(js|mjs|cjs|ts|ls|coffee|litcoffee|coffee\\.md)$', | ||
}, | ||
}, | ||
{ | ||
name: 'not-to-dev-dep', | ||
|
@@ -149,54 +140,47 @@ module.exports = { | |
'from.pathNot re of the not-to-dev-dep rule in the dependency-cruiser configuration', | ||
from: { | ||
path: '^(src)', | ||
pathNot: '\\.(spec|test)\\.(js|mjs|cjs|ts|ls|coffee|litcoffee|coffee\\.md)$' | ||
pathNot: '\\.(spec|test)\\.(js|mjs|cjs|ts|ls|coffee|litcoffee|coffee\\.md)$', | ||
}, | ||
to: { | ||
dependencyTypes: [ | ||
'npm-dev' | ||
] | ||
} | ||
dependencyTypes: ['npm-dev'], | ||
}, | ||
}, | ||
{ | ||
name: 'optional-deps-used', | ||
severity: 'info', | ||
comment: | ||
"This module depends on an npm package that is declared as an optional dependency " + | ||
'This module depends on an npm package that is declared as an optional dependency ' + | ||
"in your package.json. As this makes sense in limited situations only, it's flagged here. " + | ||
"If you're using an optional dependency here by design - add an exception to your" + | ||
"dependency-cruiser configuration.", | ||
'dependency-cruiser configuration.', | ||
from: {}, | ||
to: { | ||
dependencyTypes: [ | ||
'npm-optional' | ||
] | ||
} | ||
dependencyTypes: ['npm-optional'], | ||
}, | ||
}, | ||
{ | ||
name: 'peer-deps-used', | ||
comment: | ||
"This module depends on an npm package that is declared as a peer dependency " + | ||
"in your package.json. This makes sense if your package is e.g. a plugin, but in " + | ||
"other cases - maybe not so much. If the use of a peer dependency is intentional " + | ||
"add an exception to your dependency-cruiser configuration.", | ||
'This module depends on an npm package that is declared as a peer dependency ' + | ||
'in your package.json. This makes sense if your package is e.g. a plugin, but in ' + | ||
'other cases - maybe not so much. If the use of a peer dependency is intentional ' + | ||
'add an exception to your dependency-cruiser configuration.', | ||
severity: 'warn', | ||
from: {}, | ||
to: { | ||
dependencyTypes: [ | ||
'npm-peer' | ||
] | ||
} | ||
} | ||
dependencyTypes: ['npm-peer'], | ||
}, | ||
}, | ||
], | ||
options: { | ||
|
||
/* conditions specifying which files not to follow further when encountered: | ||
- path: a regular expression to match | ||
- dependencyTypes: see https://github.com/sverweij/dependency-cruiser/blob/master/doc/rules-reference.md#dependencytypes-and-dependencytypesnot | ||
for a complete list | ||
*/ | ||
doNotFollow: { | ||
path: 'node_modules' | ||
path: 'node_modules', | ||
}, | ||
|
||
/* conditions specifying which dependencies to exclude | ||
|
@@ -234,7 +218,7 @@ module.exports = { | |
"specify": for each dependency identify whether it only exists before compilation or also after | ||
*/ | ||
tsPreCompilationDeps: true, | ||
|
||
/* | ||
list of extensions to scan that aren't javascript or compile-to-javascript. | ||
Empty by default. Only put extensions in here that you want to take into | ||
|
@@ -260,7 +244,7 @@ module.exports = { | |
defaults to './tsconfig.json'. | ||
*/ | ||
tsConfig: { | ||
fileName: 'tsconfig.json' | ||
fileName: 'tsconfig.json', | ||
}, | ||
|
||
/* Webpack configuration to use to get resolve options from. | ||
|
@@ -309,8 +293,8 @@ module.exports = { | |
If you have an `exportsFields` attribute in your webpack config, that one | ||
will have precedence over the one specified here. | ||
*/ | ||
exportsFields: ["exports"], | ||
*/ | ||
exportsFields: ['exports'], | ||
/* List of conditions to check for in the exports field. e.g. use ['imports'] | ||
if you're only interested in exposed es6 modules, ['require'] for commonjs, | ||
or all conditions at once `(['import', 'require', 'node', 'default']`) | ||
|
@@ -320,7 +304,7 @@ module.exports = { | |
If you have a 'conditionNames' attribute in your webpack config, that one will | ||
have precedence over the one specified here. | ||
*/ | ||
conditionNames: ["import", "require", "node", "default"], | ||
conditionNames: ['import', 'require', 'node', 'default'], | ||
/* | ||
The extensions, by default are the same as the ones dependency-cruiser | ||
can access (run `npx depcruise --info` to see which ones that are in | ||
|
@@ -339,7 +323,7 @@ module.exports = { | |
this if you're not sure, but still use TypeScript. In a future version | ||
of dependency-cruiser this will likely become the default. | ||
*/ | ||
mainFields: ["main", "types"], | ||
mainFields: ['main', 'types'], | ||
}, | ||
reporterOptions: { | ||
dot: { | ||
|
@@ -440,10 +424,10 @@ module.exports = { | |
// theme: { | ||
// }, | ||
}, | ||
"text": { | ||
"highlightFocused": true | ||
text: { | ||
highlightFocused: true, | ||
}, | ||
} | ||
} | ||
}, | ||
}, | ||
}; | ||
// generated: [email protected] on 2023-03-17T15:29:26.420Z |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
**/*.spec.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
{ | ||
"root": true, | ||
"ignorePatterns": ["projects/**/*"], | ||
"parserOptions": { | ||
"ecmaVersion": "latest" | ||
}, | ||
"overrides": [ | ||
{ | ||
"files": ["*.ts"], | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"plugin:@angular-eslint/recommended", | ||
"plugin:@angular-eslint/template/process-inline-templates", | ||
"prettier" // must be last in the array | ||
], | ||
"rules": { | ||
"@angular-eslint/directive-selector": [ | ||
"error", | ||
{ | ||
"type": "attribute", | ||
"prefix": "app", | ||
"style": "camelCase" | ||
} | ||
], | ||
"@angular-eslint/component-selector": [ | ||
"error", | ||
{ | ||
"type": "element", | ||
"prefix": "app", | ||
"style": "kebab-case" | ||
} | ||
] | ||
} | ||
}, | ||
{ | ||
"files": ["*.html"], | ||
"extends": ["plugin:@angular-eslint/template/recommended", "plugin:@angular-eslint/template/accessibility"], | ||
"rules": {} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# This action will run the code formatter once a pull request is closed that targets main | ||
|
||
name: Code Formatter | ||
|
||
on: | ||
pull_request: | ||
types: | ||
- closed | ||
branches: ['main'] | ||
|
||
env: | ||
NODE_VERSION: '18.13.0' | ||
|
||
jobs: | ||
if_merged: | ||
if: github.event.pull_request.merged == true | ||
name: Install packages and format code | ||
runs-on: ubuntu-latest | ||
continue-on-error: true | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
token: ${{ secrets.BOT_ACCESS_TOKEN }} | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
|
||
- name: Install | ||
run: npm install | ||
|
||
- name: Format Code | ||
run: npx prettier . --write | ||
|
||
- name: Commit | ||
run: | | ||
git config --global user.email "[email protected]" | ||
git config --global user.name GCCollab Bot | ||
git commit -a -m "Code formatting ${{ vars.IGNORE_DEPLOY }}" | ||
git push |
Oops, something went wrong.