Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAC_SDK from 9.04 to 10.26 #303

Merged

Conversation

c72578
Copy link
Collaborator

@c72578 c72578 commented Nov 2, 2023

  • Original download location:
    https://monkeysaudio.com/files/MAC_1026_SDK.zip
    SHA256:
    cff58b2ee049bfbde131b050a7fabd216b1618d86ada3dd956e542490ae64394
  • Update the CUETools specific MACLibDll.cpp and MACLibDll.h based on
    the upstream modifications to MACDll.cpp and MACDll.h, respectively.
    • c_APEDecompress_GetData:
      Use unsigned char * pBuffer instead of char * pBuffer
      Remark: The equivalent of unsigned char in C# is byte.
    • Rename macros from MAC_ to APE_ according to upstream (10.18) [1].
      MACLibDll.h:
      MAC_COMPRESSION_LEVEL_NORMAL -> APE_COMPRESSION_LEVEL_NORMAL
      MACLibDll.cpp:
      MAC_FILE_VERSION_NUMBER -> APE_FILE_VERSION_NUMBER
      MAC_VERSION_STRING -> APE_VERSION_STRING
    • Seek() is used again in IO.h since 10.00. Furthermore it returns
      int instead of int64 since 10.01 [1].
  • Update ThirdParty_MAC_SDK_CUETools.patch accordingly
  • The fix of the exception when decoding very small APE files (316f907)
    has been submitted upstream and merged in the meantime (9.10).
  • Resolves [REQ] Monkey's Audio v10.xx #261

[1] https://monkeysaudio.com/versionhistory.html

@c72578
Copy link
Collaborator Author

c72578 commented Nov 3, 2023

Here is a build for testing, which uses MAC_SDK 10.26:
CUETools_2.2.4_2023-11-02_git_bc4fd24_Update_MAC_SDK_from_9.04_to_10.26.zip
SHA256: 2b676b928739797f5bc945900bb0f0681c7d730a4dba1d4fc574804b4b4a4686

@c72578 c72578 force-pushed the 2023-11-01_Update_MAC_SDK_from_9.04_to_10.26 branch from bc4fd24 to 2ef61c4 Compare November 4, 2023 15:31
- Original download location:
  https://monkeysaudio.com/files/MAC_1026_SDK.zip
  SHA256:
  cff58b2ee049bfbde131b050a7fabd216b1618d86ada3dd956e542490ae64394
- Update the CUETools specific MACLibDll.cpp and MACLibDll.h based on
  the upstream modifications to MACDll.cpp and MACDll.h, respectively.
  * c_APEDecompress_GetData:
    Use `unsigned char * pBuffer` instead of `char * pBuffer`
    Remark: The equivalent of unsigned char in C# is byte.
  * Rename macros from MAC_ to APE_ according to upstream (10.18) [1].
    MACLibDll.h:
      MAC_COMPRESSION_LEVEL_NORMAL -> APE_COMPRESSION_LEVEL_NORMAL
    MACLibDll.cpp:
      MAC_FILE_VERSION_NUMBER -> APE_FILE_VERSION_NUMBER
      MAC_VERSION_STRING -> APE_VERSION_STRING
  * `Seek()` is used again in IO.h since 10.00. Furthermore it returns
    int instead of int64 since 10.01 [1].
- Update ThirdParty_MAC_SDK_CUETools.patch accordingly
- The fix of the exception when decoding very small APE files (316f907)
  has been submitted upstream and merged in the meantime (9.10).
- Resolves gchudov#261

[1] https://monkeysaudio.com/versionhistory.html
@c72578 c72578 force-pushed the 2023-11-01_Update_MAC_SDK_from_9.04_to_10.26 branch from 2ef61c4 to 0835e59 Compare November 4, 2023 15:35
@c72578 c72578 merged commit c088ed5 into gchudov:master Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Monkey's Audio v10.xx
1 participant