Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monkeysaudio.com/files/MAC_1026_SDK.zip
SHA256:
cff58b2ee049bfbde131b050a7fabd216b1618d86ada3dd956e542490ae64394
the upstream modifications to MACDll.cpp and MACDll.h, respectively.
Use
unsigned char * pBuffer
instead ofchar * pBuffer
Remark: The equivalent of unsigned char in C# is byte.
MAC_
toAPE_
according to upstream (10.18) [1].MACLibDll.h:
MAC_COMPRESSION_LEVEL_NORMAL -> APE_COMPRESSION_LEVEL_NORMAL
MACLibDll.cpp:
MAC_FILE_VERSION_NUMBER -> APE_FILE_VERSION_NUMBER
MAC_VERSION_STRING -> APE_VERSION_STRING
Seek()
is used again in IO.h since 10.00. Furthermore it returnsint
instead ofint64
since 10.01 [1].ThirdParty_MAC_SDK_CUETools.patch
accordinglyhas been submitted upstream and merged in the meantime (9.10).
[1] https://monkeysaudio.com/versionhistory.html