Preserve settings for builtin formats #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Locking Encoders, Decoders, and Advanced tabs now. |
The settings of builtin formats were not disabled anymore in Settings - Formats since e1f8906 (last working in release: 2.1.7). They were only disabled at the first start of CUETools. As soon as a settings.txt file was available, this was not the case anymore. - Furthermore, this fixes availability of newly added formats like aiff, if a settings.txt file from a previous version of CUETools is already present.
c72578
force-pushed
the
2023-10-21_Preserve_settings_for_builtin_formats
branch
from
71488ef
to
6eae07c
Compare
|
@ha-korth thanks for testing and the feedback. |
|
Initial run-through looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings of builtin formats were not disabled anymore
in Settings - Formats since e1f8906 (last working in release: 2.1.7).
They were only disabled at the first start of CUETools. As soon as a
settings.txt file was available, this was not the case anymore.
aiff, if a
settings.txtfile from a previous version of CUETools isalready present.