Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid applying offset twice #288

Merged

Conversation

c72578
Copy link
Collaborator

@c72578 c72578 commented Jul 15, 2023

The offset has been applied twice in case of the scripts "repair"
or "encode if verified".

The offset has been applied twice in case of the scripts "repair"
or "encode if verified".

- Any offset is already applied during the verification step.
  Check if an offset has been applied.
- Resolves gchudov#265 and
  https://hydrogenaud.io/index.php/topic,122081.0.html
@c72578 c72578 force-pushed the 2023-07-15_Avoid_applying_offset_twice branch from a12a888 to 0853683 Compare July 15, 2023 18:17
@c72578
Copy link
Collaborator Author

c72578 commented Jul 15, 2023

Here is a build for testing, where the offset is not applied twice, when using the "repair" or "encode if verified" script:

CUETools_2.2.4_2023-07-15_git_0853683_Avoid_applying_offset_twice.zip
SHA256: a8180469c15929ba37662543b57999c956e2b9cd5af65b7cede8c534f10631ad

@c72578 c72578 merged commit 0853683 into gchudov:master Jul 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair and correct offset at once
1 participant