Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies the sdf version #95

Closed
wants to merge 1 commit into from
Closed

Conversation

Voldivh
Copy link

@Voldivh Voldivh commented Sep 12, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#459

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Voldivh Voldivh requested a review from azeey September 12, 2023 16:27
@@ -37,7 +37,7 @@ results in:

```xml
<!--SDFormat-->
<sdf version='1.9'>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary since the tutorial applies to SDFormat versions 1.9 and up. If someone was using an older version of libsdformat, it would generate 1.9.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, sounds good to me. Closing the PR then.

@Voldivh Voldivh closed this Sep 12, 2023
@Voldivh Voldivh deleted the voldivh/fix_sdf_version branch September 12, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

sdf_tutorials: SDFormat extensions to URDF (the 'gazebo' tag)
2 participants