-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionalities for optical tactile plugin #431
Add functionalities for optical tactile plugin #431
Conversation
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
Signed-off-by: Martiño Crespo <[email protected]>
CC @mabelzhang |
Will review after #229 is merged (it's very close), then will update feature branch to reduce the diffs here. |
#229 is in, moving this to "In Review"! |
I just noticed that this PR isn't targeting |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed most of the files and pushed some changes, mostly for style.
Only file I still need to review is the tests.
I'm saving the Mac CI error message from the new test, in case the link dies before I come back to fix it.
|
Signed-off-by: Mabel Zhang <[email protected]>
…o into optical_tactile_plugin_2
…c CI Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
The macOS tests are failing to load Ogre just like in gazebosim/gz-sensors#66 and gazebosim/gz-gui#145, so I disabled the test for macOS on 4ffad4d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because Mac failing tests were my only concern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! 🚀
This PR is a change of target from this PR in my fork.
This PR adds the following: