Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check camera sensors have non-zero width or height (backport #480) #483

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 11, 2024

🦟 Bug fix

Summary

Check to verify that camera sensors have non-zero width / height before creating the rendering cameras. The check prevents gz-sim from crashing and will output a more meaningful msg.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #480 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit aaef365)
@mergify mergify bot requested a review from iche033 as a code owner November 11, 2024 09:12
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 11, 2024
@ahcorde ahcorde merged commit 5b106e4 into gz-sensors8 Nov 11, 2024
10 checks passed
@ahcorde ahcorde deleted the mergify/bp/gz-sensors8/pr-480 branch November 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants