Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check camera sensors have non-zero width or height (backport #480) #482

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 11, 2024

🦟 Bug fix

Summary

Check to verify that camera sensors have non-zero width / height before creating the rendering cameras. The check prevents gz-sim from crashing and will output a more meaningful msg.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #480 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit aaef365)

# Conflicts:
#	src/RgbdCameraSensor.cc
Copy link
Author

mergify bot commented Nov 11, 2024

Cherry-pick of aaef365 has failed:

On branch mergify/bp/gz-sensors7/pr-480
Your branch is up to date with 'origin/gz-sensors7'.

You are currently cherry-picking commit aaef365.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/BoundingBoxCameraSensor.cc
	modified:   src/CameraSensor.cc
	modified:   src/DepthCameraSensor.cc
	modified:   src/SegmentationCameraSensor.cc
	modified:   src/ThermalCameraSensor.cc
	modified:   src/WideAngleCameraSensor.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/RgbdCameraSensor.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from iche033 as a code owner November 11, 2024 09:11
@mergify mergify bot added the conflicts label Nov 11, 2024
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 11, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde merged commit 4fcd8ed into gz-sensors7 Nov 11, 2024
9 checks passed
@ahcorde ahcorde deleted the mergify/bp/gz-sensors7/pr-480 branch November 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants