Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 5 #202

Merged
merged 2 commits into from
Mar 4, 2022
Merged

3 ➡️ 5 #202

merged 2 commits into from
Mar 4, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Mar 4, 2022

➡️ Forward port

Port ign-sensors3 to ign-sensors5

Branch comparison: ign-sensors5...ign-sensors3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@chapulina chapulina requested a review from iche033 as a code owner March 4, 2022 02:28
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #202 (aae1f7c) into ign-sensors5 (b45f95e) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-sensors5     #202      +/-   ##
================================================
+ Coverage         76.52%   76.62%   +0.09%     
================================================
  Files                23       23              
  Lines              2458     2468      +10     
================================================
+ Hits               1881     1891      +10     
  Misses              577      577              
Impacted Files Coverage Δ
src/AirPressureSensor.cc 83.78% <100.00%> (ø)
src/AltimeterSensor.cc 86.36% <100.00%> (ø)
src/CameraSensor.cc 73.89% <100.00%> (ø)
src/DepthCameraSensor.cc 73.77% <100.00%> (ø)
src/ImuSensor.cc 89.28% <100.00%> (ø)
src/Lidar.cc 70.98% <100.00%> (ø)
src/LogicalCameraSensor.cc 87.50% <100.00%> (ø)
src/MagnetometerSensor.cc 86.51% <100.00%> (ø)
src/RgbdCameraSensor.cc 74.24% <100.00%> (ø)
src/Sensor.cc 86.78% <100.00%> (+0.80%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe65a92...aae1f7c. Read the comment docs.

@ahcorde ahcorde enabled auto-merge March 4, 2022 08:40
@ahcorde
Copy link
Contributor

ahcorde commented Mar 4, 2022

@osrf-jenkins retest this please

1 similar comment
@ahcorde
Copy link
Contributor

ahcorde commented Mar 4, 2022

@osrf-jenkins retest this please

@ahcorde ahcorde merged commit 135d876 into ign-sensors5 Mar 4, 2022
@ahcorde ahcorde deleted the chapulina/3_to_5 branch March 4, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants