-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #387
Open
gavinlaking
wants to merge
8
commits into
master
Choose a base branch
from
updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updates #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development: - guard-minitest - minitest - minitest-reporters - mocha - rubocop - simplecov - simplecov-console - yard Runtime: - bundler
Instead of > 0, < 0, and == 0.
Some investigation is required. My local machine runs the test suite with no failure, but Travis is failing. |
Closed
Problem appears to be the size of the window the test is run in. The following rvm:
- 2.3.3
- 2.4.3
branches:
- master
- updates
os:
- osx
- linux
script:
- stty rows 120
- stty cols 120
- bundle exec rake Note that making your terminal window very small in OS X causes more test to fail. Will open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit-rot is already starting to take hold of this project with changes to Ruby and Minitest. This release fixes some of the issues noticed. There are still some deprecation warnings from Minitest.