Performance tweaks. #305
Merged
Performance tweaks. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to then fetch the respective interface for the Char, which should make colour/style fetching faster. Work relating to #302.
Work relating to #302.
Note: Stream will try to access Line, and Line will access the parent view. Work relating to #302.
Work related to #302.
Work relating to #302.
Compression is achieved by not repeatedly sending a position when only the x coordinate has changed; i.e. we are on the same line, just advancing a character. In the test application, we have gone from sending 72260 characters to the terminal to just 13971- approximately 80% reduction. Reported compression time has changed from average 20.6ms to 13.2ms- a ~35% improvement. Also, add more documentation. Work related to #302.
Work related to #302.
In Presentation::Colour and Presentation::Styles, a check has been added for whether we are dealing with a Vedeu::Views::Char- if so, then we can use the '#interface' method of that class to get the colour information instead of the slower '#parent' route. Work relating to #302.
This class will reduce duplication throughout Vedeu where an array of arrays at a given width and height are required.
This will allow us to access the related interface for its colours and styles which will be used to optimise the clearing and redrawing of a view.
This will form the basis of a new way to maintain each view.
- Extract some logic to methods for readability. - Add more documentation.
We don't need all this extra information for Editor characters.
Rather than redraw the whole screen on a document character change we update the buffer and redraw only the document area. Fixes #302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302.