-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: finish meson
porting and remove Makefiles and CMake files
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gavalian This isn't ready to be merged yet, since it needs more testing and debugging. I'll let you know when it's ready. |
for `iguana` compatibility
c-dilks
changed the title
fix: make
fix: finish Aug 22, 2024
meson
workmeson
porting and remove Makefiles and CMake files
gavalian
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks (and sounds) good.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #58
After merging this, let's tag version
4.2.0
(as set in the newmeson.build
file).Breaking Changes
pkg-config
for dependency resolution, as well as its targetsNoteworthy Changes
meson
gets confused when testing executable names that end in.exe
; I've therefore removed the file extension, and added a prefixhipo_
(to mitigate name collisions)reaction.cc
, found inextensions/julia/lib
, has been moved tohipo4/
, and built as part oflibhipo4
(rather than separately inlibjulia
); this revealed a bug infizika.h
, where include directives were found inside the namespacelz4
submodule is removedmeson
will first check the system forlz4
, if it's not found, it will use the WrapDB, which will download it, build it locally, and use it$HIPO
and$PKG_CONFIG_PATH
to be setsource
ing the installedlibexec/this_hipo.*
file (depending on your shell)meson
, but that can be a job for another PRDownstream PRs: