Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finish meson porting and remove Makefiles and CMake files #59

Merged
merged 37 commits into from
Sep 9, 2024

Conversation

c-dilks
Copy link
Contributor

@c-dilks c-dilks commented Aug 20, 2024

Continuation of #58

After merging this, let's tag version 4.2.0 (as set in the new meson.build file).

Breaking Changes

  • CMake users will need to use pkg-config for dependency resolution, as well as its targets

Noteworthy Changes

  • executable names: meson gets confused when testing executable names that end in .exe; I've therefore removed the file extension, and added a prefix hipo_ (to mitigate name collisions)
  • reaction.cc, found in extensions/julia/lib, has been moved to hipo4/, and built as part of libhipo4 (rather than separately in libjulia); this revealed a bug in fizika.h, where include directives were found inside the namespace
  • lz4 submodule is removed
    • meson will first check the system for lz4, if it's not found, it will use the WrapDB, which will download it, build it locally, and use it
  • Many remaining Makefiles require environment variables such as $HIPO and $PKG_CONFIG_PATH to be set
    • this can be done by sourceing the installed libexec/this_hipo.* file (depending on your shell)
    • these Makefiles could be converted to meson, but that can be a job for another PR
    • WARNING: these Makefiles are NOT tested!

Downstream PRs:

@c-dilks
Copy link
Contributor Author

c-dilks commented Aug 20, 2024

@gavalian This isn't ready to be merged yet, since it needs more testing and debugging. I'll let you know when it's ready.

@c-dilks c-dilks changed the title fix: make meson work fix: finish meson porting and remove Makefiles and CMake files Aug 22, 2024
@c-dilks c-dilks marked this pull request as ready for review September 9, 2024 16:10
Copy link
Owner

@gavalian gavalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (and sounds) good.

@gavalian gavalian merged commit 2009487 into gavalian:master Sep 9, 2024
5 checks passed
@c-dilks c-dilks deleted the fix-meson branch September 9, 2024 20:44
@c-dilks c-dilks mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants