Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hdf5-metno fork #40

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Use hdf5-metno fork #40

merged 3 commits into from
Aug 9, 2024

Conversation

magnusuMET
Copy link
Collaborator

No description provided.

@magnusuMET magnusuMET requested a review from gauteh August 8, 2024 13:35
@gauteh
Copy link
Owner

gauteh commented Aug 8, 2024

Looks like there's an issue with thread-safety in hdf5? Could also explain the weird issues in the other tests.

@magnusuMET
Copy link
Collaborator Author

It does not look like we require a threadsafe hdf5 since we use hdf5 for all operations (which serialises all calls to hdf5)

@magnusuMET
Copy link
Collaborator Author

That broke a lot of tests... I will test if it works if netcdf uses the same lock as hdf5 as tests pass when not using default features

@gauteh
Copy link
Owner

gauteh commented Aug 9, 2024

That broke a lot of tests... I will test if it works if netcdf uses the same lock as hdf5 as tests pass when not using default features

I think it breaks since rust runs the tests in parallel, they could be run in series on windows to avoid the problem.

@magnusuMET
Copy link
Collaborator Author

@gauteh Calls to hdf5 should be serialised properly now, even from netcdf

@gauteh
Copy link
Owner

gauteh commented Aug 9, 2024

Thanks!

@gauteh gauteh merged commit 200c1fd into gauteh:main Aug 9, 2024
16 checks passed
@magnusuMET magnusuMET deleted the feature/hdf5-metno branch August 9, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants