Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stable rust #39

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Conversation

alexander-buerger-met-no
Copy link
Contributor

No description provided.

@gauteh
Copy link
Owner

gauteh commented Jul 23, 2024

Thanks! I will take a closer look once I'm back from vacation 😊

@alexander-buerger-met-no
Copy link
Contributor Author

Ok. I think the main thing is that groub_by is now in stable under the name chunk_by (rust-lang/rust#80552).

@gauteh
Copy link
Owner

gauteh commented Jul 24, 2024

Ok. I think the main thing is that groub_by is now in stable under the name chunk_by (rust-lang/rust#80552).

Great, that is what stopped me in #27, the itertools variant was not a drop-in replacement.

- enables code using cow_is_borrowed
- enables code using new_uninit

- use Vec::chunk_by (stable since rust 1.70)
- use divan for benchmarks
- add function to create empty vec
@gauteh gauteh force-pushed the use-stable-rust branch 10 times, most recently from 049cde8 to 634a7de Compare August 8, 2024 09:42
@gauteh gauteh merged commit 8ac70b9 into gauteh:main Aug 8, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants