Add and use Extents type #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusuMET
commented
Oct 7, 2023
|
Great! Thanks. I will take a look. |
|
I thought doc-tests were already run with just |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 56.83% 58.57% +1.74%
==========================================
Files 21 22 +1
Lines 1061 1178 +117
==========================================
+ Hits 603 690 +87
- Misses 458 488 +30
|
gauteh
reviewed
Oct 7, 2023
gauteh
reviewed
Oct 7, 2023
gauteh
force-pushed
the
feature/extents
branch
from
ff3c896
to
75195de
Compare
gauteh
force-pushed
the
feature/extents
branch
from
75195de
to
203aebc
Compare
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Extents type which should make selecting data a bit more ergonomic.
This mirrors the API of the netcdf and hdf5 crates (more or less copy-paste ;) ) but is tailored to the assumptions of this crate (i.e. no strides).
This contains major breaking API changes.