Fix tach report with Python files outside source roots; parallelize
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with running
tach reportin a project which has Python files outside of known source roots.Example:
Report failed: Filesystem error: No matching source root found for filepath: "<filepath>"This is relatively common in a monorepo scenario, but
tach reportwas incorrectly trying to translate every Python file under the project root into a module path. Instead, Tach should only walk each source root, similar totach check.Also similarly to
tach check, this work can be parallelized usingrayon. It could be made much more memory efficient, but this PR keeps the behavior essentially the same as before.