Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example dependency error] sentry core should not depend on plugins #5

Closed
wants to merge 4 commits into from

Conversation

caelean
Copy link
Member

@caelean caelean commented Dec 10, 2024

Update tach config to remove sentry_plugins from sentry's dependency list.

@caelean caelean changed the title Sentry core should not depend on plugins [example dependency error] Sentry core should not depend on plugins Dec 10, 2024
@caelean caelean changed the title [example dependency error] Sentry core should not depend on plugins [example dependency error] sentry core should not depend on plugins Dec 10, 2024
@gauge-demo
Copy link

gauge-demo bot commented Dec 16, 2024

Modularity Report

Main Modularity: 8.8%
Branch Modularity: 7.07% (-1.73%)

This PR decreases modularity relative to the latest report on the main branch (2db32e4) by -1.73%.

Note: You can view the full report to dismiss these errors if they are acceptable.

Interface Errors

Usage Problem
sentry_plugins/github/plugin.py:10 integrations.base.FeatureDescription is not part of the public interface for sentry.
sentry_plugins/bitbucket/endpoints/webhook.py:14 integrations.bitbucket.constants.BITBUCKET_IP_RANGES is not part of the public interface for sentry.
sentry_plugins/pushover/plugin.py:2 integrations.base.IntegrationFeatures is not part of the public interface for sentry.
sentry_plugins/github/webhooks/events/installation_repository.py:1 integrations.models.integration.Integration is not part of the public interface for sentry.
sentry_plugins/base.py:12 shared_integrations.constants.ERR_UNAUTHORIZED is not part of the public interface for sentry.
sentry_plugins/base.py:19 shared_integrations.exceptions.UnsupportedResponseType is not part of the public interface for sentry.
sentry_plugins/pagerduty/plugin.py:1 integrations.base.FeatureDescription is not part of the public interface for sentry.
sentry_plugins/bitbucket/plugin.py:7 shared_integrations.exceptions.ApiError is not part of the public interface for sentry.
sentry_plugins/gitlab/plugin.py:3 integrations.base.FeatureDescription is not part of the public interface for sentry.
sentry_plugins/gitlab/plugin.py:3 integrations.base.IntegrationFeatures is not part of the public interface for sentry.
... ...
69 more violations. See full report for details.

Dependency Errors

Usage Problem
sentry/runner/commands/createflag.py:6 Cannot importconditions.ConditionBase. Module sentry cannot depend on flagpole.
sentry/features/flagpole_context.py:5 Cannot importevaluation_context.ContextBuilder. Module sentry cannot depend on flagpole.
sentry/runner/commands/createflag.py:6 Cannot importconditions.condition_from_dict. Module sentry cannot depend on flagpole.
sentry/runner/commands/createflag.py:6 Cannot importconditions.ConditionOperatorKind. Module sentry cannot depend on flagpole.
sentry/runner/commands/createflag.py:5 Cannot importFeature. Module sentry cannot depend on flagpole.
sentry/features/flagpole_context.py:5 Cannot importevaluation_context.EvaluationContextDict. Module sentry cannot depend on flagpole.
sentry/runner/commands/createflag.py:5 Cannot importSegment. Module sentry cannot depend on flagpole.

@caelean caelean closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant