Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translated part-five #13

Merged
merged 9 commits into from
Nov 14, 2019
Merged

translated part-five #13

merged 9 commits into from
Nov 14, 2019

Conversation

KiranAkadas
Copy link
Contributor

Addresses #1
Translated /tutorials/part-five/index.md

arshadkazmi42
arshadkazmi42 suggested changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.
I have reviewed the file till line 77.
Once you are done with fixing these, I will resume the review for rest of the file

docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
@KiranAkadas
Copy link
Contributor Author

Hey, I've fixed those

@KiranAkadas
Copy link
Contributor Author

Oh wait! I left a few

@KiranAkadas
Copy link
Contributor Author

Made all the changes !

@gatsbybot gatsbybot mentioned this pull request Nov 10, 2019
Open
62 tasks
arshadkazmi42
arshadkazmi42 suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.
I have reviewed next section till 103.
Can you work on the fixes. I will review next batch after this is completed

docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
@KiranAkadas
Copy link
Contributor Author

Done with those!

@arshadkazmi42
Copy link
Contributor

@KiranAkadas Good work. Added few comments, once you are done with those, I will continue with the review

@KiranAkadas
Copy link
Contributor Author

Yes! Made those changes

arshadkazmi42
arshadkazmi42 suggested changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the fixes till now.
I have reviewed the whole file and added couple of feedbacks.
Once these are fixed we will get this merged

Note: Please do not mark the feedbacks as resolved, just acknoledge the feedbacks using 👍 emoji or a comment. Any reviewer will review the changes and mark the feedback as resolve.
This process is really helpful duing multiple iterations of review for one file

docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-five/index.md Outdated Show resolved Hide resolved
@KiranAkadas
Copy link
Contributor Author

Sorry for marking those conversations as resolved. I didn't know about that

@KiranAkadas
Copy link
Contributor Author

I've made all the changes!

@KiranAkadas
Copy link
Contributor Author

Done!

@arshadkazmi42
Copy link
Contributor

Done!

That was quick 😱

arshadkazmi42
arshadkazmi42 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job. ❤️
Thank you for working on this and implementing all the feedback suggestions

@arshadkazmi42 arshadkazmi42 merged commit be37b28 into gatsbyjs:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

@sakshamtaneja21 sakshamtaneja21 Awaiting requested review from sakshamtaneja21

@SatyaRF SatyaRF Awaiting requested review from SatyaRF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiranAkadas @arshadkazmi42