Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation.md #154

Conversation

alvaromontoro
Copy link
Contributor

Table sorted alphabetically as commented on this thread.

Changes as part of this PR:

  • Reorder table alphabetically
  • Match upper/lower case
  • Fix minor typo (ámbito)
  • Leave all terms in lower case unless proper noun

- Reorder table alphabetically
- Match upper/lower case
- Fix minor typo (ámbito)
- Leave all terms in lower case unless proper noun
@alvaromontoro
Copy link
Contributor Author

When a word in English is not translated (e.g. key), it is wrapped in underscores to make it show in italics on preview. But there are some words that don't follow this pattern:

  • issue
  • layout
  • push (from "notificaciones push")
  • script
  • stub

I see how push and script may not needed as they are common in Spanish too, but should the other 3 be updated to _issue_, _layout_, and _stub_ respectively?

@xmartinezpujol
Copy link
Contributor

xmartinezpujol commented Nov 3, 2019

Thanks for the changes @alvaromontoro.

About the cursive words, I would go for adding all words that are not adapted to spanish in cursive (it's the common use case in spanish language). In my opinion, then all of them push, script, layout, stub included.

xmartinezpujol
xmartinezpujol previously approved these changes Nov 3, 2019
@alvaromontoro alvaromontoro added the Ready for review Pull request is ready for a maintainer to review it label Nov 3, 2019
@alvaromontoro
Copy link
Contributor Author

@xmartinezpujol I made those changes to display them on cursive.

Copy link
Contributor

@gusma gusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente, @alvaromontoro.

@gusma gusma merged commit 02796db into gatsbyjs:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Pull request is ready for a maintainer to review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants