add huffman table constructor from symbol-bitsize range #96
Conversation
oliverlee
force-pushed
the
Ia125173ce91e2e189c23de0956d9eaa7aa51762c
branch
from
96394da
to
d7a2481
Compare
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 95.86% 98.62% +2.75%
==========================================
Files 11 11
Lines 290 290
==========================================
+ Hits 278 286 +8
+ Misses 12 4 -8
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oliverlee
force-pushed
the
Ic42b6b1c03f10077d19d49a9e6544214834ba42f
branch
from
8b144ef
to
5bb362f
Compare
oliverlee
force-pushed
the
Ia125173ce91e2e189c23de0956d9eaa7aa51762c
branch
from
d7a2481
to
3cb36c5
Compare
oliverlee
force-pushed
the
Ia125173ce91e2e189c23de0956d9eaa7aa51762c
branch
from
3cb36c5
to
8bac466
Compare
oliverlee
force-pushed
the
Ic42b6b1c03f10077d19d49a9e6544214834ba42f
branch
from
0396f5d
to
bf73c0e
Compare
oliverlee
force-pushed
the
Ia125173ce91e2e189c23de0956d9eaa7aa51762c
branch
3 times, most recently
from
fb781a1
to
3079c1d
Compare
| namespace huffman = ::starflate::huffman; | ||
| using namespace huffman::literals; | ||
|
|
||
| test("table with DEFLATE canonical code, example 1") = [] { |
There was a problem hiding this comment.
If these examples are from the RFC, please add that in a comment or put that in the test desc string (like RFC example 1 instead of example 1).
Also, do we get any more code coverage from having 2 examples vs just 1? If not then probably just 1 is enough.
There was a problem hiding this comment.
I think coverage will be the same with one example vs two. I'll remove the smaller one and update the test description to include "RFC"
There was a problem hiding this comment.
Updated descriptions and added links to RFC examples. Coverage comes from the second test. First test verifies usability in constant expressions. I've replaced expect with static_assert to make that more clear.
oliverlee
force-pushed
the
Ic42b6b1c03f10077d19d49a9e6544214834ba42f
branch
2 times, most recently
from
6fffff8
to
0d12cbb
Compare
oliverlee
force-pushed
the
Ia125173ce91e2e189c23de0956d9eaa7aa51762c
branch
from
3079c1d
to
f596820
Compare
Add a constructor to huffman::table that takes a range of symbol-bitsize tuples. This commit also moves public tag types into a utility header. Change-Id: Ia125173ce91e2e189c23de0956d9eaa7aa51762c
oliverlee
force-pushed
the
Ia125173ce91e2e189c23de0956d9eaa7aa51762c
branch
from
f596820
to
5360f66
Compare
Add a constructor to huffman::table that takes a range of symbol-bitsize
tuples.
This commit also moves public tag types into a utility header.
Change-Id: Ia125173ce91e2e189c23de0956d9eaa7aa51762c