Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define huffman::table::canonicalize() #88

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

oliverlee
Copy link
Collaborator

huffman::table::canonicalize() updates the existing codes in a table to
canonical form for DEFLATE:

  • All codes of a given bit length have lexicographically consecutive
    values, in the same order as the symbols they represent;
  • Shorter codes lexicographically precede longer codes.

Change-Id: Idc3dceefe1b5d17a54f1dab29155a499c7e1d138

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Merging #88 (e8d816c) into Ic3798d8976d664827085a3f30374730ba3039645 (041bcb8) will decrease coverage by 0.75%.
The diff coverage is 90.47%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                              Coverage Diff                              @@
##           Ic3798d8976d664827085a3f30374730ba3039645      #88      +/-   ##
=============================================================================
- Coverage                                      99.57%   98.82%   -0.75%     
=============================================================================
  Files                                             11       11              
  Lines                                            236      256      +20     
=============================================================================
+ Hits                                             235      253      +18     
- Misses                                             1        3       +2     
Files Changed Coverage Δ
huffman/src/detail/table_storage.hpp 100.00% <ø> (ø)
huffman/src/table.hpp 97.10% <90.47%> (-2.90%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oliverlee oliverlee force-pushed the Idc3dceefe1b5d17a54f1dab29155a499c7e1d138 branch 4 times, most recently from f66e59e to 4bf9e5f Compare September 23, 2023 15:57
@oliverlee oliverlee force-pushed the Idc3dceefe1b5d17a54f1dab29155a499c7e1d138 branch from 4bf9e5f to e8d816c Compare September 24, 2023 00:59
@garymm garymm force-pushed the Ic3798d8976d664827085a3f30374730ba3039645 branch from 041bcb8 to 13d5177 Compare September 25, 2023 23:56
Base automatically changed from Ic3798d8976d664827085a3f30374730ba3039645 to master September 26, 2023 00:06
@garymm garymm force-pushed the Idc3dceefe1b5d17a54f1dab29155a499c7e1d138 branch from e8d816c to 3b9ba47 Compare September 26, 2023 00:30
@garymm garymm enabled auto-merge (squash) September 26, 2023 00:30
huffman::table::canonicalize() updates the existing codes in a table to
canonical form for DEFLATE:
 * All codes of a given bit length have lexicographically consecutive
   values, in the same order as the symbols they represent;
 * Shorter codes lexicographically precede longer codes.

Change-Id: Idc3dceefe1b5d17a54f1dab29155a499c7e1d138
@garymm garymm force-pushed the Idc3dceefe1b5d17a54f1dab29155a499c7e1d138 branch from 3b9ba47 to be508eb Compare September 26, 2023 00:31
@garymm garymm enabled auto-merge (squash) September 26, 2023 00:31
@garymm garymm merged commit aaa683d into master Sep 26, 2023
13 checks passed
@garymm garymm deleted the Idc3dceefe1b5d17a54f1dab29155a499c7e1d138 branch September 26, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants