Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define stream insertion for std::byte in tests #114

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

oliverlee
Copy link
Collaborator

Change-Id: I5dca691416482ae27ab31bc176fd5217b8e3fd8f

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fddc29) 97.79% compared to head (0803a3a) 97.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files          15       15           
  Lines         408      408           
=======================================
  Hits          399      399           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverlee oliverlee force-pushed the I08edcc3e240a44a04b09a8ba787030665134f3a8 branch from ff860df to fa67996 Compare November 22, 2023 03:52
@oliverlee oliverlee force-pushed the I5dca691416482ae27ab31bc176fd5217b8e3fd8f branch 2 times, most recently from 5482af4 to b15303a Compare November 22, 2023 04:17
Copy link
Owner

@garymm garymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm another reason to consider using a type other than byte.

@oliverlee oliverlee force-pushed the I08edcc3e240a44a04b09a8ba787030665134f3a8 branch from fa67996 to 9e9d56f Compare November 23, 2023 01:06
Base automatically changed from I08edcc3e240a44a04b09a8ba787030665134f3a8 to master November 23, 2023 01:14
Change-Id: I5dca691416482ae27ab31bc176fd5217b8e3fd8f
@oliverlee oliverlee force-pushed the I5dca691416482ae27ab31bc176fd5217b8e3fd8f branch from b15303a to 0803a3a Compare November 23, 2023 01:28
@oliverlee oliverlee enabled auto-merge (squash) November 23, 2023 01:28
@oliverlee oliverlee merged commit 427ca92 into master Nov 23, 2023
15 checks passed
@oliverlee oliverlee deleted the I5dca691416482ae27ab31bc176fd5217b8e3fd8f branch November 23, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants