Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compare): add layoutSettings state persistence (#1519) #1538

Merged

Conversation

dgrebb
Copy link
Contributor

@dgrebb dgrebb commented Jan 18, 2024

Summary

Enhance user experience by enabling persistent compare report settings across sessions.

Potentially closes #1519.

Solution

Implemented Redux state persistence and hydration using localStorage. This update focuses on layoutSettings:

  • Adds state persistence and hydration with Redux.
  • Defaults to defaultState.
  • Implements error handling: catches, warns, and clears localStorage issues.

Notes

Bugfixes and Enhancements

  • Updated webpack-dev-server configuration and npm run dev-compare.
  • Removed toggleTextInfo from SettingsPopup.js in the compare module.
    • Identified as legacy code. Further analysis suggests onToggle can be repurposed for updating any setting by id.

@dgrebb dgrebb force-pushed the feat/1519-suiteInfo-localStorage-hydration branch from 7df1533 to 68d3ed8 Compare January 18, 2024 01:25
@dgrebb dgrebb mentioned this pull request Jan 18, 2024
@dgrebb
Copy link
Contributor Author

dgrebb commented Jan 18, 2024

@garris here's a moving picture as well:

Demo

BackstopJS With Persisted Compare Settings

@garris garris merged commit f0d84b4 into garris:master Feb 1, 2024
2 checks passed
@dgrebb dgrebb deleted the feat/1519-suiteInfo-localStorage-hydration branch April 30, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show details by default
2 participants