Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to override the report base path for resources #1094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svwu
Copy link
Contributor

@svwu svwu commented Sep 6, 2019

For our CI Integration, we need to specify the baseUrl where the Report loads resources from.
It may be an edge case but it's really necessary for us.

I opened an Issue aswell:
#1093

@svwu
Copy link
Contributor Author

svwu commented Sep 11, 2019

We fixed the problem in our CI with some workarounds - this PR is not necessary for us anymore.
If it is useful for others, it can be considered to be still merged or not.

@garris
Copy link
Owner

garris commented Sep 11, 2019

Thanks @svwu. Just curious how you solved the issue. Please post if you have a second. Cheers!

@svwu
Copy link
Contributor Author

svwu commented Sep 12, 2019

Hey garris!
It was a bit tricky, cause we use Docker Swarm and run different BackstopJS tasks for different environments including different backstop.json files.
We implemented a workflow which copies the files to a persistent place which wasn't accessible for our html report in Jenkins. Now we added a build step which also creates a symlink to the correct persistent folder. So we won't need a configureable static path which is accessible
.

@garris
Copy link
Owner

garris commented Sep 12, 2019

Got it. yes, this is very similar to what we are doing in our CI as well. Thanks for the update -- hope all is well! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants