This repository has been archived by the owner on May 26, 2024. It is now read-only.
Make IP pool names configurable in MachineClass
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @timebertt |
gardener-robot
added
needs/review
timebertt
approved these changes
May 14, 2024
timebertt
changed the title
MachineClassMachineClass
timebertt
force-pushed
the
hackathon-provider-local-vpn
branch
from
fed542e
to
4fa3736
Compare
timebertt
approved these changes
May 14, 2024
|
/lgtm for @timebertt changes |
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 26, 2024
…ocal#42 This code can only be removed with gardener#9752
gardener-prow bot
pushed a commit
to gardener/gardener
that referenced
this pull request
May 26, 2024
…ner` (#9782) * Fix logcheck for logr look-alike package-level funcs Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Move `machine-controller-manager-provider-local` Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Add ko as a local tool Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Use entrypoint of mcm sidecar image Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Build provider-local-node image in skaffold Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Build mcm provider-local image in skaffold Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Update dependencies of custom builders in skaffold Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Remove obsolete image Image is always provided by the kind cluster config yaml. Hence, this `--image` flag never had any effect because it was always overwritten. Co-Authored-By: Rafael Franzke <[email protected]> Co-Authored-By: Marcel Boehm <[email protected]> * Go back to simplified image names * Doc nits * Go back to `0.0.0` for local node image version * Partially revert gardener-attic/machine-controller-manager-provider-local#42 This code can only be removed with #9752 --------- Co-authored-by: Rafael Franzke <[email protected]> Co-authored-by: Marcel Boehm <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the name of the calico IP pools configurable via the
MachineClass.The
Serviceis dropped because the respectiveNetworkPolicys are no longer needed since no seed component should directly talk to the machine pods (communication should always happen via the VPN tunnel only).The
to-shoot-networksnetwork policy label is dropped becausegardener/gardenerwill drop the respectiveNetworkPolicyentirely (TODO: reference PR here).Which issue(s) this PR fixes:
Part of gardener/gardener#9604
Release note: