Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the lesson page spacing and elements #3118

Merged
merged 12 commits into from
Jul 15, 2023

Conversation

flacial
Copy link
Member

@flacial flacial commented Jul 14, 2023

Changes

  • Increase the h3 font size from 16px to 20px because when the text is short, it's hard to read it
  • Add a top margin for every heading & paragraph element to make the content look less cramped
  • Remove the pencil icon from the text "Edit this page" to simplify the look of it (the icon isn't compatible with the icons we use in the app)
  • Add spacing between the lesson content elements: next/previous lesson, lesson text content, and challenge bar
  • Redesign the ChallengeBar

Screenshots

Before & After headings:

before
image

after:
image

pencil icon

before:
image

after:
image

Challenge bar

before:
image

after:
image

Lesson content elements

before:
image

after:
image

Related PRs

#2321

@vercel
Copy link

vercel bot commented Jul 14, 2023

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 8:08am

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #3118 (3d1dabf) into master (98917a0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3d1dabf differs from pull request most recent head e39b054. Consider uploading reports for the commit e39b054 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines         3644      3645    +1     
  Branches       992       992           
=========================================
+ Hits          3644      3645    +1     
Impacted Files Coverage Δ
components/EditPage/EditPage.tsx 100.00% <ø> (ø)
components/mdx/ChallengBar.tsx 100.00% <ø> (ø)
helpers/mdxComponents.tsx 100.00% <100.00%> (ø)
pages/curriculum/[lessonSlug]/[subLessonSlug].tsx 100.00% <100.00%> (ø)

Copy link
Collaborator

@scotthallock scotthallock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots look great!

@flacial flacial enabled auto-merge July 15, 2023 08:04
@flacial flacial added this pull request to the merge queue Jul 15, 2023
Merged via the queue into garageScript:master with commit 6c5d4c1 Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants