Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removed column to the Exercise table #2614

Merged

Conversation

flacial
Copy link
Member

@flacial flacial commented Dec 16, 2022

Related to #2630

Description

The implementation we've now for removing an exercise after it has been flagged is different from what is in the design doc. In the design doc, a removed exercise means it'll not appear to the students, not completely removed from the database.

This PR which adds the removed column and the following ones aims at fixing this mistake.

@vercel
Copy link

vercel bot commented Dec 16, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Dec 18, 2022 at 0:15AM (UTC)

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2614 (0f3a8e4) into master (cd11572) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2614   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines         3437      3437           
  Branches       954       954           
=========================================
  Hits          3437      3437           
Impacted Files Coverage Δ
__dummy__/getExercisesData.ts 100.00% <ø> (ø)

@flacial flacial self-assigned this Dec 18, 2022
@flacial flacial merged commit bca6a74 into garageScript:master Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

2 participants