-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add removed
column to the Exercise table
#2614
Merged
flacial
merged 7 commits into
garageScript:master
from
flacial:2601-handle-already-flagged-exercises
Dec 18, 2022
Merged
Add removed
column to the Exercise table
#2614
flacial
merged 7 commits into
garageScript:master
from
flacial:2601-handle-already-flagged-exercises
Dec 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2614 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 187 187
Lines 3437 3437
Branches 954 954
=========================================
Hits 3437 3437
|
HS-90
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2630
Description
The implementation we've now for removing an exercise after it has been flagged is different from what is in the design doc. In the design doc, a removed exercise means it'll not appear to the students, not completely removed from the database.
This PR which adds the
removed
column and the following ones aims at fixing this mistake.