Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates formValidation and adminHelpers #1617

Closed
wants to merge 8 commits into from

Conversation

anso3
Copy link
Collaborator

@anso3 anso3 commented Mar 19, 2022

This pr update formValidation and adminHelpers to include module related information.
This will allow future the admin module page components to use the form components.
Admin module page is the next step in #1192
FormValidations will now have module schema to error check module information.
adminHelpers now changes 'lessonId' in a form, from a string to a int which is require for a graphql mutation.

adminHelper test were updated to include 'lessonId'

@vercel
Copy link

vercel bot commented Mar 19, 2022

@mino323 is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel.

@garageScript first needs to authorize it.

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@8068d34). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 1728fd9 differs from pull request most recent head 7714d64. Consider uploading reports for the commit 7714d64 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             master     #1617   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       157           
  Lines             ?      2636           
  Branches          ?       680           
==========================================
  Hits              ?      2636           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
helpers/admin/adminHelpers.ts 100.00% <100.00%> (ø)
helpers/formValidation.tsx 100.00% <100.00%> (ø)

@vercel
Copy link

vercel bot commented Mar 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c0d3/c0d3-app/2NJgJUWpCaNRk8F98Khczh71LhW1
✅ Preview: https://c0d3-app-git-fork-mino323-adminpage-c0d3.vercel.app

@@ -37,6 +37,15 @@ const lessonSchema = Yup.object({
chatUrl: Yup.string()
})

const moduleSchema = Yup.object({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moduleSchemaValidation to match the file naming pattern of name+vValidation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good idea to keep things consistent.

@anso3 anso3 closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants