-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates formValidation and adminHelpers #1617
Conversation
@mino323 is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel. @garageScript first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 157
Lines ? 2636
Branches ? 680
==========================================
Hits ? 2636
Misses ? 0
Partials ? 0
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/2NJgJUWpCaNRk8F98Khczh71LhW1 |
@@ -37,6 +37,15 @@ const lessonSchema = Yup.object({ | |||
chatUrl: Yup.string() | |||
}) | |||
|
|||
const moduleSchema = Yup.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moduleSchemaValidation
to match the file naming pattern of name+vValidation
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good idea to keep things consistent.
This pr update formValidation and adminHelpers to include module related information.
This will allow future the admin module page components to use the form components.
Admin module page is the next step in #1192
FormValidations will now have module schema to error check module information.
adminHelpers now changes 'lessonId' in a form, from a string to a int which is require for a graphql mutation.
adminHelper test were updated to include 'lessonId'