Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flagged exercises in accordance with design doc #2630

Closed
flacial opened this issue Dec 21, 2022 · 1 comment
Closed

Remove flagged exercises in accordance with design doc #2630

flacial opened this issue Dec 21, 2022 · 1 comment
Assignees
Labels
mistake Something wrong

Comments

@flacial
Copy link
Member

flacial commented Dec 21, 2022

Description

The current implementation for removing flagged exercises differs from the design doc. According to the design doc (#1192), a removed exercise should not be visible to students, but it should not be completely removed from the database.

We should update the implementation to match the design doc. This will ensure that the app behaves as intended and meets the requirements outlined in the design doc.

Steps to reproduce:

  1. Remove an exercise with deleteExercise as inappropriate
  2. Observe that the exercise is removed from the database instead of just being hidden from students

Expected behavior:

Removed exercises should be hidden from students, but not completely removed from the database

Actual behavior:

Removed exercises are completely removed from the database

Solution

Update the implementation for removing flagged exercises to match the design doc. This will involve modifying the code so that flagged exercises are hidden from students, but not completely removed from the database.

Plan

Create a resolver that specifically applies the solution, create the fields bool named removed, user named removedBy, and date named removedAt in the Exercise schema.

@flacial flacial added the mistake Something wrong label Dec 21, 2022
@flacial flacial moved this to 📋 Backlog in C0D3-APP Team Sprints Dec 24, 2022
@flacial flacial self-assigned this Dec 26, 2022
@flacial flacial moved this from 📋 Backlog to 🏗 In progress in C0D3-APP Team Sprints Dec 29, 2022
@flacial flacial changed the title Incorrect implementation for removing exercises Remove flagged exercises in accordance with design doc Jan 1, 2023
@flacial flacial moved this from 🏗 In progress to 👀 In review in C0D3-APP Team Sprints Jan 3, 2023
@flacial flacial moved this from 👀 In review to 🏗 In progress in C0D3-APP Team Sprints Jan 3, 2023
@flacial
Copy link
Member Author

flacial commented Jan 9, 2023

Closed in #2668

@flacial flacial closed this as completed Jan 9, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🦄 Done in C0D3-APP Team Sprints Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mistake Something wrong
Projects
Status: 🦄 Done
Development

No branches or pull requests

1 participant