Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the lesson content page #2321

Open
flacial opened this issue Sep 17, 2022 · 8 comments
Open

Redesign the lesson content page #2321

flacial opened this issue Sep 17, 2022 · 8 comments
Labels

Comments

@flacial
Copy link
Member

flacial commented Sep 17, 2022

Things to redesign

Lesson parts nav Large and unstyled image
Elements spacing & letter spacing Margin between elements and codeblocks image image
Fonts The fonts are inconsistent. The should be `Inter` font image
Challengebar font, size, colors, weight, and letters spacing image
Table of content It's too large image
Text length It's hard to read lengthy text image

We can use the design mock we created in the past for this page. I think it would do the job.

@flacial flacial added good first issue Good for newcomers UI User Interface redesign labels Sep 17, 2022
@flacial flacial self-assigned this Sep 17, 2022
@akshayishaan
Copy link

Is anyone working in this issue? I want to work on this issue. Can @flacial explain a bit more about it?

@flacial
Copy link
Member Author

flacial commented Sep 18, 2022

Is anyone working in this issue? I want to work on this issue. Can @flacial explain a bit more about it?

No one is working on this issue. The main thing to do is to change the page's design to this mock design. Doing so will fix some UI issues that affect the student experience while studying (also polish the page).

If you're planning to take this issue, let's chat on Discord. My username there is Flacial#1292

@akshayishaan
Copy link

@flacial It was my bad.....in understanding your issue. Unfortunately i am not a designer. I thought you have the design and You need me to code this up. Anyways.....I am new here, exploring open source issues. Nice talking to you.

@SlyBouhafs SlyBouhafs self-assigned this Sep 19, 2022
@anthonykhoa
Copy link
Collaborator

I thought you have the design and You need me to code this up.

From what I understand, the designs are ready and someone needs to code them up. I think you misunderstood @flacial's words

@flacial flacial removed the good first issue Good for newcomers label Sep 19, 2022
@flacial flacial moved this to 📋 Backlog in C0D3-APP Team Sprints Nov 21, 2022
@flacial flacial moved this from 📋 Backlog to 🔖 Ready in C0D3-APP Team Sprints Nov 29, 2022
@flacial flacial moved this from 🔖 Ready to 📋 Backlog in C0D3-APP Team Sprints Nov 29, 2022
@flacial flacial removed their assignment Nov 30, 2022
@SlyBouhafs
Copy link
Member

After a bit of tweaking, thanks to @flacial for the help, here is the new lessons page redesign to match our new design, there are two variants, left TOC and right TOC, we can vote on which one we should implement.

Right TOC page:

Image

Right TOC scroll:

Image

Left TOC page:

Image

Left TOC scroll:

Image

If you guys have any feedback, i would love to hear it.

@flacial
Copy link
Member Author

flacial commented Dec 4, 2022

@SlyBouhafs I vote for Left TOC page. It looks perfect!

@flacial
Copy link
Member Author

flacial commented Dec 4, 2022

I like the idea of having a container around the content (especially headers):

image

With the current design, things look like they're floating around and nothing to contain them (not pretty):

image

@SlyBouhafs
Copy link
Member

SlyBouhafs commented Dec 6, 2022

With the current design, things look like they're floating around and nothing to contain them (not pretty):

I agree, that header is mostly for students/mentors, we need to adapt it so that it works with the admin pages too, i will work on that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants