Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display String support #44

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Display String support #44

merged 3 commits into from
Jan 2, 2024

Conversation

gapple
Copy link
Owner

@gapple gapple commented Jan 2, 2024

Fixes #43

@gapple gapple added the enhancement New feature or request label Jan 2, 2024
@gapple gapple added this to the 2.1.0 milestone Jan 2, 2024
@gapple gapple self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6113e97) 100.00% compared to head (d5bc5a7) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop       #44   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       173       188   +15     
===========================================
  Files             11        12    +1     
  Lines            397       436   +39     
===========================================
+ Hits             397       436   +39     
Flag Coverage Δ
phpunit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gapple gapple merged commit fea0bb5 into develop Jan 2, 2024
8 checks passed
@gapple gapple deleted the displaystring branch January 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Display String type
1 participant