Remove unnecessary extra type check for Iterator

gapple · Jan 6, 2024 · 76779d7 · 76779d7
1 parent 2beaae7
commit 76779d7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/Serializer.php b/src/Serializer.php
@@ -48,9 +48,7 @@ public static function serializeItem($value, ?object $parameters = null): string
  public static function serializeList(iterable $value): string
  {
  if ($value instanceof \Traversable) {
- if ($value instanceof \IteratorAggregate) {
- $value = $value->getIterator();
- }
+ // @todo Checking for Traversable is not required for PHP ^8.2.0.
  $value = iterator_to_array($value);
  }
 

diff --git a/tests/SerializeListTest.php b/tests/SerializeListTest.php
@@ -65,4 +65,19 @@ public function testIterable(): void
  $serialized
  );
  }
+
+ public function testArray(): void
+ {
+ $list = [
+ new Item('test'),
+ new Item(42),
+ ];
+
+ $serialized = Serializer::serializeList($list);
+
+ $this->assertEquals(
+ '"test", 42',
+ $serialized
+ );
+ }
 }