Improve manual_build docs. #93
Conversation
| PUID="${PUID=0}" \ | ||
| PGID="${PGID=0}" \ |
There was a problem hiding this comment.
These two aren't used by Wolf, they are just used by the Docker container to setup the running user
|
|
||
| : ${WOLF_CFG_FOLDER="config"} | ||
|
|
||
| XDG_RUNTIME_DIR="${XDG_RUNTIME_DIR=/tmp/sockets}" \ |
There was a problem hiding this comment.
The format for all those env variables is odd, I thought that this was possible:
# This will set XDG_RUNTIME_DIR if it wasn't set already
${XDG_RUNTIME_DIR:=/tmp/sockets}or
# This will override XDG_RUNTIME_DIR if not set
XDG_RUNTIME_DIR="${XDG_RUNTIME_DIR:-/tmp/sockets}"You don't put : though and use the = which seems to work from a quick test on the CLI but I'm not sure if there's any pitfall when doing this..
There was a problem hiding this comment.
I'll do some tests tonight to see what's going on. looking at the patch, it does strike me as odd syntax and i think it probably should be :=.
There was a problem hiding this comment.
hey @robjh,
Just reading through this PR, how did the tests go?
There was a problem hiding this comment.
apologies @salty2011, this fell off my radar. Thank you for the reminder, i'll get to this within the next few days. If i dont, feel free to give me a poke on discord.
There was a problem hiding this comment.
okay! tests done :)
:- is the appropriate operator for those variables. I've updated the commit and rebased on the latest from the stable branch.
robjh
force-pushed
the
manual-build-docs
branch
from
7c5e6d2
to
9788455
Compare
In following the instructions recently, I found the following issues; - wolf required the "-fPIC" CFLAG to build correctly. - the outputted binary was in a different directory than the one indicated. - the document didn't mention docker, as a wolf runtime dependency. - since the last commit, replace = with :- when creating the shell script.
robjh
force-pushed
the
manual-build-docs
branch
from
9788455
to
c129a10
Compare
|
Thanks for the PR and sorry this has taken me so long to finish but I wanted to add a mention to |
In following the instructions to manually build Wolf recently, I found the following issues;
This PR aims to fix these issues.