Skip to content

Commit

Permalink
ztest: use ASSERT3P to compare pointers
Browse files Browse the repository at this point in the history
With a sufficiently modern gcc (I saw this with gcc13), gcc complains
when casting pointers to an integer of a different type (even a larger
one).  On 32-bt ASSERT3U does this on 32-bit systems by casting a 32-bit
pointer to uint64_t so use ASSERT3P which uses uintptr_t.

Fixes: 5caeef0 RAID-Z expansion feature

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Brooks Davis <[email protected]>
Closes openzfs#16115
  • Loading branch information
brooksdavis authored and gamanakis committed Sep 16, 2024
1 parent c723818 commit 8b59015
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/ztest.c
Original file line number Diff line number Diff line change
Expand Up @@ -8047,7 +8047,7 @@ ztest_raidz_expand_run(ztest_shared_t *zs, spa_t *spa)
ztest_expand_io_t *thread_args;

ASSERT3U(ztest_opts.zo_raidz_expand_test, !=, RAIDZ_EXPAND_NONE);
ASSERT3U(rzvd->vdev_ops, ==, &vdev_raidz_ops);
ASSERT3P(rzvd->vdev_ops, ==, &vdev_raidz_ops);
ztest_opts.zo_raidz_expand_test = RAIDZ_EXPAND_STARTED;

/* Setup a 1 MiB buffer of random data */
Expand Down

0 comments on commit 8b59015

Please sign in to comment.