Implements some tricks to have correct sizes for the buttons #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+477
to
+484
| if (tb.getItemCount() == 0 && PlatformHelper.isWindows() && control != null) { | ||
| final var icon = GamaIcon.ofSize(2, GamaToolbarFactory.TOOLBAR_HEIGHT); | ||
| final var button = new ToolItem(tb, SWT.NONE); | ||
| final var im = icon.image(); | ||
| button.setImage(im); | ||
| button.setDisabledImage(im); | ||
| button.setEnabled(false); | ||
| } |
There was a problem hiding this comment.
❌ New issue: Complex Method
create has a cyclomatic complexity of 11, threshold = 9
| // button.setDisabledImage(im); | ||
| // button.setEnabled(false); | ||
| // } | ||
| if (tb.getItemCount() == 0 && PlatformHelper.isWindows() && control != null) { |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
create has 1 complex conditionals with 2 branches, threshold = 2
| @@ -57,58 +57,59 @@ public class GamaToolbar2 extends Composite { | |||
| /** The has tooltip. */ | |||
| private boolean hasTooltip; | |||
|
|
|||
| /** The height. */ | |||
There was a problem hiding this comment.
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 62.34% to 61.33%, threshold = 30.0%
|
I didn't see any change in buttons, could you explain what it is supposed to fix exactly ? |
|
It is supposed to fix the annoying size of the experiment buttons in editors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.