Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an operator to send a GAMAimage to websocket using base64 #365

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

ptaillandier
Copy link
Contributor

No description provided.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.03 (9.10 -> 9.07)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

@lesquoyb
Copy link
Contributor

Maybe we could have the format as a parameter of the operator ?
If it's not possible then could you update the documentation to make it clear that it will be saved as png ?

Also, the documentation is mentioning taking a screenshot of a display which I guess is some remaining of a copy paste code ?

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.03 (9.10 -> 9.08)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.03 (9.10 -> 9.07)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

@@ -23,6 +23,13 @@
import java.awt.image.ColorModel;
import java.awt.image.RescaleOp;
import java.awt.image.WritableRaster;
import java.io.ByteArrayOutputStream;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 31.76% to 31.52%, threshold = 30.0%

@lesquoyb lesquoyb merged commit b8a5667 into 2024-06 Nov 4, 2024
6 checks passed
@lesquoyb lesquoyb deleted the operator_image_to_websocket branch November 4, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants