Disables the lock when the camera is dynamic #353
Conversation
|
Should fix #350 |
AlexisDrogoul
added
About UI
AlexisDrogoul
changed the title
|
It works, but one side effect is that setting a camera with |
The "dynamic" and "locked" states are now clearly separated in terms of logic. While "dynamic: true" prevents the camera to be manipulated and disables the lock button, "locked: true" will allow the user to overcome the state from the UI.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| if (cameraLocked != null) { | ||
| boolean locked = view.isCameraLocked(); | ||
| boolean dynamic = view.isCameraDynamic(); | ||
| tb.setSelection(cameraLocked, locked || dynamic); | ||
| // If the camera is dynamic, we disable the control (see #350) | ||
| cameraLocked.setEnabled(!dynamic); | ||
| } |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
install increases in cyclomatic complexity from 13 to 14, threshold = 9
| @@ -688,7 +688,12 @@ public void setZFar(final Double zF) { | |||
| public void update(final IScope scope, final Facets facets) { | |||
|
|
|||
| if (cameraNameExpression != null) { | |||
| boolean isLocked = camera == null ? false : camera.isLocked(); | |||
There was a problem hiding this comment.
❌ New issue: Bumpy Road Ahead
update has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function
| @@ -144,7 +143,7 @@ public void update(final IScope scope) { | |||
| */ | |||
| @Override | |||
| public boolean setLocation(final GamaPoint loc) { | |||
| if (!isInteractive() || loc == null) return false; | |||
| if (isLocked() || isDynamic() || loc == null) return false; | |||
There was a problem hiding this comment.
❌ New issue: Complex Conditional
setLocation has 1 complex conditionals with 2 branches, threshold = 2
| @@ -159,7 +158,7 @@ public boolean setLocation(final GamaPoint loc) { | |||
| */ | |||
| @Override | |||
| public boolean setTarget(final GamaPoint loc) { | |||
| if (!isInteractive() || loc == null) return false; | |||
| if (isLocked() || isDynamic() || loc == null) return false; | |||
There was a problem hiding this comment.
❌ New issue: Complex Conditional
setTarget has 1 complex conditionals with 2 branches, threshold = 2
|
|
||
| @Override | ||
| public boolean setDistance(final Double d) { | ||
| if (!isInteractive() || d == null) return false; | ||
| if (isLocked() || isDynamic() || d == null) return false; |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
setDistance has 1 complex conditionals with 2 branches, threshold = 2
No description provided.