Change tasks context column type from text to longtext

.github/workflows/tests.yml

@@ -0,0 +1,74 @@
+name: test suite
+
+on: [push, pull_request]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php-versions: ['7.4', '8.0', '8.1']
+    env:
+      DB_DATABASE: gallery3
+      DB_USER: root
+      DB_PASSWORD: root
+      DB_PORT: 3306
+      DB_HOST: 127.0.0.1
+    steps:
+      - name: Install OS packages
+        run: sudo apt-get install imagemagick graphicsmagick dcraw ffmpeg git
+
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Set up MySQL
+        run: |
+          sudo /etc/init.d/mysql start
+          mysql -e 'CREATE DATABASE ${{ env.DB_DATABASE }};' -u${{ env.DB_USER }} -p${{ env.DB_PASSWORD }}
+          mysql -e 'CREATE DATABASE ${{ env.DB_DATABASE }}_test;' -u${{ env.DB_USER }} -p${{ env.DB_PASSWORD }}
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-versions }}
+          extensions: mbstring, gd, mysql, xml
+          ini-values: post_max_size=256M, max_execution_time=180
+          tools: composer:v2
+
+      - name: Get composer cache directory
+        id: composer-cache
+        run: |
+          mkdir -p .cache
+          echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+      - name: Cache dependencies
+        uses: actions/cache@v2
+        with:
+          path: |
+            ${{ steps.composer-cache.outputs.dir }}
+            ~/.cache
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-
+
+      - name: Install dependencies
+        run: composer install
+
+#      - name: Setup tmate session
+#        uses: mxschmitt/action-tmate@v3
+
+      - name: linter
+        run: bin/linter.sh
+
+      - name: phpcs
+        run: bin/phpcs.sh
+
+      - name: install db
+        run: php ./installer/index.php
+        env:
+          MYSQL_HOST: ${{ env.DB_HOST }}:${{ env.DB_PORT }}
+          MYSQL_USER: ${{ env.DB_USER }}
+          MYSQL_PASSWORD: ${{ env.DB_PASSWORD }}
+
+      - name: tests
+        run: php index.php test

.gitignore

@@ -1,9 +1,12 @@
 # We store Gallery3 data in var
 var
+vendor
 
 # local.php is a local customization point that gets loaded at the end of index.php
 local.php
 
 # http://codex.galleryproject.org/Gallery3:Using_Vagrant
 Vagrantfile
 .vagrant
+
+*.swp

.htaccess

@@ -4,7 +4,17 @@
 # mirrored in php.ini
 #
 <IfModule mod_php5.c>
-  php_flag short_open_tag            On
+  php_flag magic_quotes_gpc          Off
+  php_flag magic_quotes_sybase       Off
+  php_flag magic_quotes_runtime      Off
+  php_flag register_globals          Off
+  php_flag session.auto_start        Off
+  php_flag suhosin.session.encrypt   Off
+  php_value upload_max_filesize      20M
+  php_value post_max_size 	     100M
+</IfModule>
+
+<IfModule mod_php7.c>
   php_flag magic_quotes_gpc          Off
   php_flag magic_quotes_sybase       Off
   php_flag magic_quotes_runtime      Off

.phpcs.xml

@@ -0,0 +1,80 @@
+<?xml version="1.0"?>
+<ruleset name="KPQuote Standards">
+	<config name="installed_paths" value="vendor/phpcompatibility/php-compatibility" />
+	<config name="testVersion" value="8.1" />
+
+	<exclude-pattern>*\.(inc|css|js)$</exclude-pattern>
+
+	<file>./application</file>
+	<file>./lib</file>
+	<file>./system</file>
+	<file>./modules</file>
+	<file>./themes</file>
+	<file>./installer</file>
+
+	<arg name="colors"/>
+	<arg name="tab-width" value="4"/>
+	<arg name="report" value="full"/>
+	<arg name="parallel" value="2"/>
+
+	<ini name="memory_limit" value="512M"/>
+
+	<rule ref="PHPCompatibility" />
+
+	<rule ref="PHPCompatibility.Extensions.RemovedExtensions">
+		<exclude name="PHPCompatibility.Extensions.RemovedExtensions.mysql_DeprecatedRemoved"/>
+	</rule>
+
+	<rule ref="PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue">
+		<exclude name="PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.Changed"/>
+	</rule>
+
+	<rule ref="PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue">
+		<exclude name="PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection"/>
+	</rule>
+
+	<rule ref="PHPCompatibility.FunctionUse.RemovedFunctions">
+		<exclude name="PHPCompatibility.FunctionUse.RemovedFunctions.mcrypt_get_iv_sizeDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.FunctionUse.RemovedFunctions.mcrypt_create_ivDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.FunctionUse.RemovedFunctions.mcrypt_encryptDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.FunctionUse.RemovedFunctions.mcrypt_decryptDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.FunctionUse.RemovedFunctions.mcrypt_get_key_sizeDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_dev_urandomDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_dev_randomDeprecatedRemoved"/>
+	</rule>
+
+	<rule ref="PHPCompatibility.Constants.RemovedConstants">
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_mode_nofbDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_rijndael_128DeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_rijndael_256DeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_randDeprecatedRemoved"/>
+		<exclude name="PHPCompatibility.Constants.RemovedConstants.mcrypt_mode_ecbDeprecatedRemoved"/>
+	</rule>
+
+	<rule ref="PHPCompatibility.Extensions.RemovedExtensions">
+		<exclude name="PHPCompatibility.Extensions.RemovedExtensions.mcryptDeprecatedRemoved"/>
+	</rule>
+
+<!--
+	<rule ref="Squiz">
+		<exclude name="Squiz.Commenting"/>
+		<exclude name="Squiz.NamingConventions.ValidVariableName.NotCamelCaps"/>
+		<exclude name="Squiz.Operators.ComparisonOperatorUsage.ImplicitTrue"/>
+		<exclude name="Squiz.PHP.EmbeddedPhp.SpacingAfterOpen"/>
+		<exclude name="Zend.Files.ClosingTag.NotAllowed"/>
+	</rule>
+
+	<rule ref="Generic.PHP.DisallowShortOpenTag">
+		<exclude name="Generic.PHP.DisallowShortOpenTag.Found"/>
+		<exclude name="Generic.PHP.DisallowShortOpenTag.EchoFound"/>
+	</rule>
+
+	<rule ref="Generic.WhiteSpace.ScopeIndent">
+		<properties>
+			<property name="indent" value="4"/>
+			<property name="tabIndent" value="true"/>
+		</properties>
+	</rule>
+
+-->
+</ruleset>

README.md

@@ -1,8 +1,6 @@
 Gallery 3.1+ (development version)
 ==================================
 
-[![Build Status](https://travis-ci.org/gallery/gallery3.png?branch=master)](https://travis-ci.org/gallery/gallery3)
-
 About
 -----
 
@@ -21,24 +19,22 @@ welcome theme and module developers to play with this release and
 start turning out slick new designs for our happy users.  If you have
 questions or problems, you can get help in the Gallery forums:
 
-  http://galleryproject.org/forum/96
+  https://groups.google.com/forum/#!forum/gallery-3-users
 
 Security
 --------
 
-We've contracted a professional security audit, received their results
-and resolved all the issues they found.
-
-Did you find a security flaw?  Please email [email protected]
-with the details and we'll fix it ASAP!
+Did you find a security flaw?  Please submit an issue in github:
+https://github.com/bwdutton/gallery3/issues
 
 Supported Configuration
 -----------------------
 
  - Platform: Linux / Unix.
  - Web server: Apache 2.2 and newer.
- - PHP 5.2.3 and newer (PHP's safe_mode must be disabled and simplexml,
-   filter, and json must be installed).
+ - PHP 7.4 and newer (PHP's safe_mode must be disabled and simplexml,
+   filter, and json must be installed). All PHP 7.x versions should work but only 7.4 is tested
+ - short_open_tag isn't required but additional modules and themes may rely on it.
  - Database: MySQL 5 and newer.
 
 For complete system requirements, please refer to:
@@ -47,6 +43,18 @@ For complete system requirements, please refer to:
 
 Installing and Upgrading Instructions
 -------------------------------------
+**NOTE:** When upgrading from PHP 5 to PHP 7 you will need to change the database type from mysql to mysqli in var/database.php:
+```php
+$config['default'] = array(
+  'benchmark'     => false,
+  'persistent'    => false,
+  'connection'    => array(
+    'type'     => 'mysqli',
+```
+
+For docker installations:
+
+  https://hub.docker.com/r/bwdutton/gallery3
 
 For comprehensive instructions, The online User Guide is your best resource:
 
@@ -76,16 +84,22 @@ php installer/index.php [-h host] [-u user] [-p pass] [-d dbname]
  -x     Table prefix           (default: )
 ```
 
-Bugs?
------
+### Optional dependencies
 
-Go to http://apps.sourceforge.net/trac/gallery/ click the "login" link
-and log in with your SourceForge username and password, then click the
-"new ticket" button.
+Install composer dependencies to make all of the modules work (currently autorotate, phpmailer). In the top level gallery directory where the composer.json file exists run the following:
 
-Questions, Problems
--------------------
+```sh
+composer install
+```
+
+Bugs, Questions, Problems?
+--------------------------
 
  - Check out the Gallery 3 FAQ: http://codex.galleryproject.org/Gallery3:FAQ
- - Post to the Gallery 3 forums: http://galleryproject.org/forum/96
- - Email [email protected]
+ - Try the support group: https://groups.google.com/forum/#!forum/gallery-3-users
+
+### Forgot your password? Use the command line:
+
+```sh
+php index.php passwordreset <username>
+```

application/config/config.php

@@ -40,7 +40,7 @@
  *
  * Rawurlencode each of the elements to avoid breaking the page layout.
  */
-$config["site_domain"] =
+$config["site_domain"] = getEnv('SITE_DOMAIN') ? getEnv('SITE_DOMAIN') :
   implode("/", array_map("rawurlencode", explode("/",
       substr($_SERVER["SCRIPT_NAME"], 0,
              strpos($_SERVER["SCRIPT_NAME"], basename($_SERVER["SCRIPT_FILENAME"]))))));
@@ -50,7 +50,7 @@
  * specified, then the current protocol is used, or when possible, only an
  * absolute path (with no protocol/domain) is used.
  */
-$config["site_protocol"] = "";
+$config["site_protocol"] = getEnv('SITE_PROTOCOL') ? getEnv('SITE_PROTOCOL') : "";
 
 /**
  * Name of the front controller for this application. Default: index.php
@@ -64,6 +64,13 @@
  */
 $config["url_suffix"] = "";
 
+/**
+ * For non Apache servers (.e.g nginx), we don't have .htaccess files to block access.
+ * All requests to the var directory are proxied through the /file_proxy/ for access checks.
+ * We still create the files in the event you want to change web servers.
+ */
+$config["no_htaccess"] = isset($_SERVER["SERVER_SOFTWARE"]) && preg_match('/nginx/', $_SERVER["SERVER_SOFTWARE"]) ? "1" : "";
+
 /**
  * Length of time of the internal cache in seconds. 0 or FALSE means no caching.
  * The internal cache stores file paths and config entries across requests and
@@ -150,6 +157,10 @@
 );
 
 if (TEST_MODE) {
+  $config["site_domain"] = '.';
+  $config["site_protocol"] = 'http';
+  $config["index_page"] = 'index.php';
+
   array_splice($config["modules"], 0, 0,
                array(MODPATH . "gallery_unit_test",
                      MODPATH . "unit_test"));