Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ToucableOpacity to icon #184

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

added ToucableOpacity to icon #184

wants to merge 1 commit into from

Conversation

DanishWajid
Copy link

In case like search bar you need input icon to be pressable

@palingheorghe
Copy link
Collaborator

Hi @DanishWajid ! Input already has a "pressable right icon" used for password visibility. You could modify the component so it could accept TouchableOpacity on all icons used on the right side only if the user wants that. A prop for verifying what the user wants could be called "rightIconClick".

Thanks,
Alin

@DanishWajid
Copy link
Author

DanishWajid commented Feb 7, 2020 via email

@palingheorghe
Copy link
Collaborator

palingheorghe commented Feb 7, 2020

I know their different but duplicate code isn't helping. Being the fact that both icons are on the right side of the input you could re-write the component in a way much cleaner and helpful for future releases. You could actually have the option to make any icon pressable.

Edit: Please read our Wiki and our CONTRIBUTING files. The PR should be for our dev branch, not our master branch. There are now some conflicting files which need to be solved.

@palingheorghe palingheorghe changed the base branch from master to dev February 7, 2020 07:56
@DanishWajid
Copy link
Author

DanishWajid commented Feb 7, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants