Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable authorization functions #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

caje731
Copy link

@caje731 caje731 commented Apr 7, 2015

While authenticating a user and fetching the access token, the functions currently do not accept parameters that override the initial config. This can be a hassle when you'd want to change the config at runtime.
For example, if the specified redirect_uri in the config is www.my_redirect.com, I'd want to pass some data to the redirect handler, to allow dynamic behaviour,
like so : www.my_redirect.com?q=runtimeValue
which would help the redirect handler logic to behave differently.

These commits parameterize the functions to allow this behaviour.

@caje731
Copy link
Author

caje731 commented Apr 16, 2015

ping @galen

@GreatPotato
Copy link

I'm having the exact same issues, modifying the redirect_uri always gives a "Redirect URI doesn't match original redirect URI" error.

I'm having to work around this currently by saving the states in session before redirecting, and them reading them on return. Works, but not the most efficient way.

@caje731
Copy link
Author

caje731 commented Apr 23, 2015

@GreatPotato yes, that's the same issue I faced, which made me create this pull request.

@galen I'm pretty sure many others would have encountered this problem, working around it in their own ways. That's why I think it'll be nice to have this commit merged. Will ease a lot of similar problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants