Print fake shell commands. #785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of raw shell scripting was replaced with Python system calls in 9539589, that is great but the cool reporting of the shell commands was lost. This restores the reporting as fake shell commands corresponding to what is happening (sort of).
nsoranzo
reviewed
Feb 27, 2018
|
|
||
| def makedirs(path): | ||
| info("mkdir -p '%s'" % path) | ||
| os.makedirs(path) |
There was a problem hiding this comment.
A slight difference between mkdir -p and os.makedirs() is that the former succeeds even if the directory already exists, while the latter fails. You may want to guard this with an if not os.path.exists(path):
|
If you still want this, I'd prefer human-friendly messages to fake shell commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of raw shell scripting was replaced with Python system calls in 9539589, that is great but the cool reporting of the shell commands was lost. This restores the reporting as fake shell commands corresponding to what is happening (sort of).
In the spirit of something @erasche proposed doing in #100.