Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of training metadata.yaml files #1439

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

nsoranzo
Copy link
Member

Fix #1415 .

@nsoranzo nsoranzo requested a review from hexylena March 26, 2024 14:30
@nsoranzo nsoranzo enabled auto-merge March 26, 2024 14:30
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we test or should we somehow test that the generated yaml file is valid (wrt to a schema)? Does GTN has one? Should we request one?

I kind of do not understood why those internal (variable) names need to be renamed instead of just changing the display or giving a proper definition. But this is a different question.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this more general question the PR seems fine.

@nsoranzo nsoranzo merged commit 5b10a24 into galaxyproject:master Apr 2, 2024
14 checks passed
@nsoranzo nsoranzo deleted the editorial_board branch April 2, 2024 13:12
@hexylena
Copy link
Member

hexylena commented Apr 2, 2024

Do we test or should we somehow test that the generated yaml file is valid (wrt to a schema)? Does GTN has one? Should we request one?

the gtn has one, yes. but we are also considering alternative implementations that would be more integrated into the GTN, so, i'm not sure if it's worth the effort.

the schema is here: https://github.com/galaxyproject/training-material/blob/main/bin/schema-tutorial.yaml, but it does some non-standard things (namely replacing keywords like CONTRIBUTORS with their associated key upon parsing, and the 'examples' key that isn't part of kwalify, because those lists are also controlled but in separate data sources.)

We could emit a proper schema at an api endpoint that would be up-to-date if need be, just name the preferred format.

I kind of do not understood why those internal (variable) names need to be renamed

for me it would've been equivalent, yes, but i can see wanting to be sure all references are updated correctly.

@nsoranzo
Copy link
Member Author

nsoranzo commented Apr 2, 2024

I kind of do not understood why those internal (variable) names need to be renamed

for me it would've been equivalent, yes, but i can see wanting to be sure all references are updated correctly.

Indeed, keeping variable names synced with the corresponding references was easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planemo training_init creates maintainers not editorial_board
3 participants