Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool linting add --skip_file and remove lxml schema validation #1420

Merged
merged 10 commits into from
May 8, 2024
Merged

Tool linting add --skip_file and remove lxml schema validation #1420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e18735
remove lxml based schema linter
bernt-matthias Dec 15, 2023
06a8295
disable xsd linting default
bernt-matthias Dec 15, 2023
800e67b
planemo lint: add --skip_file
bernt-matthias Dec 15, 2023
901b289
Revert "remove lxml based schema linter"
bernt-matthias Dec 15, 2023
30becfa
apply black
bernt-matthias Dec 15, 2023
59a799c
fix multiple definition of `TEST_DATA_DIR`
bernt-matthias Jan 16, 2024
19f6e7b
add test for skip_file
bernt-matthias Jan 16, 2024
fa28605
implement check if skipped linters are available
bernt-matthias Jan 16, 2024
7ad8fb2
fix indentation
bernt-matthias May 2, 2024
cb9d50f
drop --xsd option
bernt-matthias May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion planemo/commands/cmd_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
@options.report_xunit()
@options.fail_level_option()
@options.skip_options()
@options.lint_xsd_option()
@options.recursive_option()
@click.option(
"--urls",
Expand Down
1 change: 0 additions & 1 deletion planemo/commands/cmd_shed_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
@options.click.option(
"--tools", is_flag=True, default=False, help=("Lint tools discovered in the process of linting repositories.")
)
@options.lint_xsd_option()
@options.click.option(
"--ensure_metadata",
is_flag=True,
Expand Down
6 changes: 0 additions & 6 deletions planemo/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,12 +1375,6 @@ def shed_fail_fast_option():
)


def lint_xsd_option():
return planemo_option(
"--xsd/--no_xsd", is_flag=True, default=False, help=("Include tool XSD validation in linting process.")
)


def lint_biocontainers_option():
return planemo_option(
"biocontainer",
Expand Down
2 changes: 0 additions & 2 deletions planemo/tool_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ def lint_tools_on_path(ctx, paths, lint_args, **kwds):

def _lint_extra_modules(**kwds):
linters = []
if kwds.get("xsd", True):
linters.append(planemo.linters.xsd)
mvdbeek marked this conversation as resolved.
Show resolved Hide resolved

if kwds.get("doi", False):
linters.append(planemo.linters.doi)
Expand Down