Minor tweaks to workflow author linting

galaxyproject · Jul 4, 2024 · 918d23b · 918d23b
1 parent ee7c30b
commit 918d23b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/planemo/workflow_lint.py b/planemo/workflow_lint.py
@@ -211,11 +211,13 @@ def check_json_for_untyped_params(j):
         lint_context.warn("Workflow is not annotated.")
 
     # creator
-    if not len(workflow_dict.get("creator", [])) > 0:
+    creators = workflow_dict.get("creator", [])
+    if not len(creators) > 0:
         lint_context.warn("Workflow does not specify a creator.")
     else:
-        creators = workflow_dict.get("creator")
         if not isinstance(creators, list):
+            # Don't know if this can happen, if we implement schema validation on the Galaxy side
+            # this won't be needed.
             creators = [creators]
         for creator in creators:
             if creator.get("class", "").lower() == "person" and "identifier" in creator: